Please review java.util.formatter bug fix

2013-08-13 Thread roger riggs
Hi, The tests for java.util.Formatter were failing in the th_TH locale. The test incorrectly relied on the locale defined calendar instantiation. Java.util.formatter should be using YEAR_OF_ERA to extract the year to get consistent results with the Japanese Calendar, for the other calendars it

Re: Please review java.util.formatter bug fix

2013-08-13 Thread Xueming Shen
Looks fine. Since you have already turned the verbose off and reduced the locales, it might be worth still letting it run N=12. The original idea with 12 is that it increases the chance of running into daylight saving on and off cases. -Sherman On 08/13/2013 12:06 PM, roger riggs wrote: Hi,

Re: Please review java.util.formatter bug fix

2013-08-13 Thread roger riggs
HI Sherman, Thanks for the review, I should have restored N=12 after debugging; the previous non-error output was hiding what I needed to see. If we want to hit DST changes then blanketing 2/3 weeks or weekends in the spring or fall might have a greater chance of a hit then 12/365. Thanks,