Re: Proposed patch: further wrapping of FileInputStream's native method

> On 16 Nov 2016, at 16:13, Claes Redestad wrote: > > Hi Paul, > > it appears you missed out on all the fun this time: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-November/044628.html > Indeed! I missed that it moved to a separate email thread. Thanks for checking. Paul.

Re: Proposed patch: further wrapping of FileInputStream's native method

Hi Paul, it appears you missed out on all the fun this time: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-November/044628.html Thanks! /Claes On 2016-11-17 00:50, Paul Sandoz wrote: Hi Sunny, If you send me an exported patch with the reviewers in the comment etc i can push fo

Re: Proposed patch: further wrapping of FileInputStream's native method

Hi Sunny, If you send me an exported patch with the reviewers in the comment etc i can push for you. Thanks, Paul. > On 9 Nov 2016, at 19:02, Chan, Sunny wrote: > > Hello all, > > I proposed a patch to provide wrapping for some native methods in > FileInputStream a while ago in May, and the

Proposed patch: further wrapping of FileInputStream's native method

Hello all, I proposed a patch to provide wrapping for some native methods in FileInputStream a while ago in May, and the patch has been reviewed but it has not been integrated. I have checked the patch again with the latest JDK9 dev builds and it still works correctly passing java.io regression

Re: Proposed patch: further wrapping of FileInputStream's native method

On 10/05/2016 08:13, Chan, Sunny wrote: The available() and sync() are the only native methods in the FileInputStream that has not been "wrapped". Our use case is that we have an internal storage implementation and we would like to be able to provide support for older applications that use ja

RE: Proposed patch: further wrapping of FileInputStream's native method

7;; Brian Burkhalter Subject: Re: Proposed patch: further wrapping of FileInputStream's native method The changes in your patch look ok. It is not clear, at least to me, why these methods are all that interesting, or even why they were not covered by 8054720. Maybe Brian Burkhalter, or other

Re: Proposed patch: further wrapping of FileInputStream's native method

On 09/05/2016 14:26, Chris Hegarty wrote: The changes in your patch look ok. It is not clear, at least to me, why these methods are all that interesting, or even why they were not covered by 8054720. Maybe Brian Burkhalter, or others may know. The changes look okay to me but just to mention t

Re: Proposed patch: further wrapping of FileInputStream's native method

The changes in your patch look ok. It is not clear, at least to me, why these methods are all that interesting, or even why they were not covered by 8054720. Maybe Brian Burkhalter, or others may know. -Chris. On 09/05/16 04:27, Chan, Sunny wrote: Previously in JDK-8054720

Proposed patch: further wrapping of FileInputStream's native method

Previously in JDK-8054720, a number of native methods has been wrapped in order to allow instrumentation. We would like to propose to wrap a number of other methods (available(), skip()) so that we can perform further instrumentation. I have atta