Re: Fix proposal for bug JDK-8221642

2022-01-31 Thread Alan Bateman
On 31/01/2022 09:21, Andreas Rosenberg wrote: Hi Mandy, thanks for your comments. Yes, the correct solution is to examine each caller sensitive method. Surely my idea is not perfect, as the problem with the ResourceBundle and the bootstrap loader shows. I had the hope that cases like this coul

Re: Fix proposal for bug JDK-8221642

2022-01-28 Thread Mandy Chung
54 *To:* Andreas Rosenberg *Cc:* hotspot-...@openjdk.java.net; 'core-libs-dev' *Subject:* Re: Fix proposal for bug JDK-8221642 I see how NPE is thrown (from `AccessibleObject::setAccessible` and `trySetAccessible`). The proper fix should follow the rule as the access check that it can set the acces

RE: Fix proposal for bug JDK-8221642

2022-01-28 Thread Andreas Rosenberg
would be great. Andreas From: Mandy Chung Sent: Freitag, 28. Januar 2022 02:54 To: Andreas Rosenberg Cc: hotspot-...@openjdk.java.net; 'core-libs-dev' Subject: Re: Fix proposal for bug JDK-8221642 I see how NPE is thrown (from `AccessibleObject::setAccessible` and `trySetAccessib

Re: Fix proposal for bug JDK-8221642

2022-01-27 Thread Mandy Chung
I see how NPE is thrown (from `AccessibleObject::setAccessible` and `trySetAccessible`).  The proper fix should follow the rule as the access check that it can set the accessible flag only on public members of a public type that is exported unconditionally. The fix is straight forward but invo

Re: Fix proposal for bug JDK-8221642

2022-01-27 Thread Mandy Chung
Hi Andreas, What methods are you calling that throws NPE?  Do you have the stack trace to share? The spec of AccessibleObject was updated for JDK-8221530 if there is no caller frame when calling from JNI: "The check when invoked by JNI code with no Java class on the stack only succeeds if