Re: RFR(XS):JDK-8219228: java/util/Base64/TestEncodingDecodingLength.java failing on 8GB test machine.

2019-02-19 Thread Naoto Sato
+1 Naoto On 2/19/19 7:10 AM, Roger Riggs wrote: Looks fine,  Reviewed. On 02/19/2019 04:05 AM, Nishit Jain wrote: Hi Arno, Although I don't know if turning off or no swap is expected for a test environment, but tried reproducing the issue locally on a 8Gb Ubuntu linux VM with swap turned

Re: RFR(XS):JDK-8219228: java/util/Base64/TestEncodingDecodingLength.java failing on 8GB test machine.

2019-02-19 Thread Roger Riggs
Looks fine,  Reviewed. On 02/19/2019 04:05 AM, Nishit Jain wrote: Hi Arno, Although I don't know if turning off or no swap is expected for a test environment, but tried reproducing the issue locally on a 8Gb Ubuntu linux VM with swap turned off, the test case was passing until I started

RE: RFR(XS):JDK-8219228: java/util/Base64/TestEncodingDecodingLength.java failing on 8GB test machine.

2019-02-19 Thread Zeller, Arno
Hi Nishit, thanks for testing! Best regards, Arno >-Original Message- >From: Nishit Jain >Sent: Dienstag, 19. Februar 2019 10:05 >To: Zeller, Arno ; core-libs-dev d...@openjdk.java.net> >Subject: Re: RFR(XS):JDK-8219228: >java/util/Base64/TestEncodingDecodingLengt

Re: RFR(XS):JDK-8219228: java/util/Base64/TestEncodingDecodingLength.java failing on 8GB test machine.

2019-02-19 Thread Nishit Jain
Hi Arno, Although I don't know if turning off or no swap is expected for a test environment, but tried reproducing the issue locally on a 8Gb Ubuntu linux VM with swap turned off, the test case was passing until I started some other app (like browser) in parallel, in which case it failed with

RE: RFR(XS):JDK-8219228: java/util/Base64/TestEncodingDecodingLength.java failing on 8GB test machine.

2019-02-18 Thread Langer, Christoph
Hi Arno, this looks good and trivial. I'll sponsor this one. Maybe one of the authors/reviewers of the original fix for bug https://bugs.openjdk.java.net/browse/JDK-8218265 (Nishit, Roger, Naoto) should approve this. Thanks Christoph > -Original Message- > From: core-libs-dev On