Looks good!
Thanks,
David
On 7/12/2019 11:34 pm, gerard ziemski wrote:
Hi all,
Please review this revision 2 of a cleanup, where we remove
JDK_GetVersionInfo0 and related code, since we can get build versions
directly from within the VM itself.
The rev2 differs from rev1 in that it's simpl
Looks good.
Mandy
On 12/7/19 5:34 AM, gerard ziemski wrote:
Hi all,
Please review this revision 2 of a cleanup, where we remove
JDK_GetVersionInfo0 and related code, since we can get build versions
directly from within the VM itself.
The rev2 differs from rev1 in that it's simpler due to J
> ; Langer, Christoph
>
> Subject: Re: RFR (M) 8223261 "JDK-8189208 followup - remove
> JDK_GetVersionInfo0 and the supporting code"
>
> Hi all,
>
> Please review this revision 2 of a cleanup, where we remove
> JDK_GetVersionInfo0 and related code, since we c
Looks good to me!
/Claes
On 2019-12-07 14:34, gerard ziemski wrote:
Hi all,
Please review this revision 2 of a cleanup, where we remove
JDK_GetVersionInfo0 and related code, since we can get build versions
directly from within the VM itself.
The rev2 differs from rev1 in that it's simpler
Hi all,
Please review this revision 2 of a cleanup, where we remove
JDK_GetVersionInfo0 and related code, since we can get build versions
directly from within the VM itself.
The rev2 differs from rev1 in that it's simpler due to JDK-8234185,
which was just checked in yesterday. Waiting for t
2019 20:30
To: gerard ziemski
Cc: awt-...@openjdk.java.net; hotspot-dev developers ; core-libs-dev@openjdk.java.net
Subject: Re: RFR (M) 8223261 "JDK-8189208 followup - remove
JDK_GetVersionInfo0 and the supporting code"
On 11/13/19 10:50 AM, gerard ziemski wrote:
Hi all,
Ple
an official review thread tomorrow...
Thanks
Christoph
-Original Message-
From: hotspot-dev On Behalf Of
Mandy Chung
Sent: Mittwoch, 13. November 2019 20:30
To: gerard ziemski
Cc: awt-...@openjdk.java.net; hotspot-dev developers ; core-libs-dev@openjdk.java.net
Subject: Re: RFR (M) 8223
iemski
Cc: awt-...@openjdk.java.net; hotspot-dev developers ; core-libs-dev@openjdk.java.net
Subject: Re: RFR (M) 8223261 "JDK-8189208 followup - remove
JDK_GetVersionInfo0 and the supporting code"
On 11/13/19 10:50 AM, gerard ziemski wrote:
Hi all,
Please review this cleanup, where we remov
Thank you for the review, will remove the comment and updated the
webrev, but only after Christop Langer gets his fix in - I'm going to
wait for him to check in first.
cheers
On 11/13/19 1:29 PM, Mandy Chung wrote:
On 11/13/19 10:50 AM, gerard ziemski wrote:
Hi all,
Please review this cl
Looks fine.
On 11/13/19 10:50 am, gerard ziemski wrote:
Hi all,
Please review this cleanup, where we remove JDK_GetVersionInfo0 and related
code, since we can get build versions directly from within the VM itself:
I'm including core-libs and awt in this review because the proposed fix touches
tomorrow...
Thanks
Christoph
-Original Message-
From: hotspot-dev On Behalf Of
Mandy Chung
Sent: Mittwoch, 13. November 2019 20:30
To: gerard ziemski
Cc: awt-...@openjdk.java.net; hotspot-dev developers ; core-libs-dev@openjdk.java.net
Subject: Re: RFR (M) 8223261 "JDK-
Christoph
> -Original Message-
> From: hotspot-dev On Behalf Of
> Mandy Chung
> Sent: Mittwoch, 13. November 2019 20:30
> To: gerard ziemski
> Cc: awt-...@openjdk.java.net; hotspot-dev developers d...@openjdk.java.net>; core-libs-dev@openjdk.java.net
> Subject: Re: RFR (M) 8223
On 11/13/19 10:50 AM, gerard ziemski wrote:
Hi all,
Please review this cleanup, where we remove JDK_GetVersionInfo0 and
related code, since we can get build versions directly from within the
VM itself:
I'm including core-libs and awt in this review because the proposed
fix touches their
On 2019-11-13 19:50, gerard ziemski wrote:
webrev: http://cr.openjdk.java.net/~gziemski/8223261_rev1
Nice cleanup! Looks good to me.
/Claes
14 matches
Mail list logo
