Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

Hi John, thank you very much - some comments are inlined below. > Am 28.09.2016 um 08:26 schrieb John Rose : > > Reviewed. This is a huge leap forward. > > A few small comments to consider: > > In FacLoop, the argument k should be named acc: > +- int fin(int i, int k) { return k; } > ++ int

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

On Sep 26, 2016, at 12:01 PM, Michael Haupt wrote: > > thank you very much for your reviews - may I ask for a second round? > > The updated webrev is at > http://cr.openjdk.java.net/~mhaupt/8151179/webrev.01/ >

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

Hello, reviews, please ... ? Thanks, Michael > Am 26.09.2016 um 21:01 schrieb Michael Haupt : > > Hi John, all, > > thank you very much for your reviews - may I ask for a second round? > > The updated webrev is at > http://cr.openjdk.java.net/~mhaupt/8151179/webrev.01/ >

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

Hi John, all, thank you very much for your reviews - may I ask for a second round? The updated webrev is at http://cr.openjdk.java.net/~mhaupt/8151179/webrev.01/ ; an accompanying specdiff, at http://cr.openjdk.java.net/~mhaupt/8151179/spec

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

I'm working on this. The javadoc has some re-filling which creates lots of diffs of whitespace only, which makes things go a little slower. I am trying to like the cleaner, more restricted semantics for the utility methods, but they really do some harm to the use cases. The really notable cha

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

On 2016-08-12 02:27, Michael Haupt wrote: Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8151179 Webrev: http://cr.openjdk.java.net/~mhaupt/8151179/webrev.00/ Looks good to me. /Claes The change addresses concerns about the JEP 274 API that were raised b

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

... anyone, please? :-) Thanks, Michael > Am 12.08.2016 um 02:27 schrieb Michael Haupt : > > Dear all, > > please review this change. > Bug: https://bugs.openjdk.java.net/browse/JDK-8151179 > Webrev: http://cr.openjdk.java.net/~mhaupt/8151179/webrev.00/ > > The change addresses concerns about

RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8151179 Webrev: http://cr.openjdk.java.net/~mhaupt/8151179/webrev.00/ The change addresses concerns about the JEP 274 API that were raised by the JCK team. One consequence is that the convenience wrappers for the