Thanks a lot for reviewing, Mandy!
Jiangli
> On Jul 6, 2018, at 1:40 PM, mandy chung wrote:
>
> Hi Jiangli,
>
> On 6/28/18 4:15 PM, Jiangli Zhou wrote:> webrev:
> http://cr.openjdk.java.net/~jiangli/8202035/webrev.00/
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8202035?filter=14921
>
>
> On Jul 6, 2018, at 1:36 PM, Ioi Lam wrote:
>
> Hi Jiangli,
>
> The VM changes look good to me.
Thanks!
>
> For the tests: I think we need a comment here saying that "mods" is
> intentionally empty, and also an explanation why it's not necessary to
> actually fill with actual modules?
W
Hi Jiangli,
On 6/28/18 4:15 PM, Jiangli Zhou wrote:> webrev:
http://cr.openjdk.java.net/~jiangli/8202035/webrev.00/
RFE: https://bugs.openjdk.java.net/browse/JDK-8202035?filter=14921
Good work. I'm glad to see a pretty good startup improvement.
I reviewed java.base change that looks good.
Hi Jiangli,
The VM changes look good to me.
For the tests: I think we need a comment here saying that "mods" is
intentionally empty, and also an explanation why it's not necessary to
actually fill with actual modules?
Thanks
- Ioi
3) ArchivedModuleComboTest.java
55 Path module
Hi Calvin,
Thanks for the review! Here is the updated webrevs that address the feedbacks
from you and Ioi:
http://cr.openjdk.java.net/~jiangli/8202035/webrev_inc.01/
Full webrev: http://cr.openjdk.java.net/~jiangli/8202035/webrev_full.01/
> On Jul 6, 2018, at 9:15 AM, Calvin Cheung wrote:
>
Hi Jiangli,
Thanks for this start-up improvement. The changes look good overall.
I've the following minor comments.
1) make/hotspot/symbols/symbols-unix
134 JVM_InitializeFromArchive
If you want the symbols to be in alphabetical order, the above
should be moved after JVM_InitStackTr
Hi Ioi,
Thanks for the review!
> On Jul 5, 2018, at 5:45 PM, Ioi Lam wrote:
>
> Hi Jiangli,
>
> Thank you so much for working on this. I think it's great that we can get the
> start-up improvement by archiving the ModuleDescriptor.
>
> I just have some coding style comments regarding heapShar
Hi Jiangli,
Thank you so much for working on this. I think it's great that we can
get the
start-up improvement by archiving the ModuleDescriptor.
I just have some coding style comments regarding heapShared.cpp. This file
contains the code for coping objects and relocating pointers. By its natu
Hi Erik,
Thank you for the quick review!
Jiangli
> On Jun 28, 2018, at 5:44 PM, Erik Joelsson wrote:
>
> Build changes look good.
>
> /Erik
>
>
> On 2018-06-28 16:15, Jiangli Zhou wrote:
>> This is a follow-up RFE of JDK-8201650 (Move iteration order randomization
>> of unmodifiable Set an
Build changes look good.
/Erik
On 2018-06-28 16:15, Jiangli Zhou wrote:
This is a follow-up RFE of JDK-8201650 (Move iteration order randomization of
unmodifiable Set and Map to iterators), which was resolved to allow Set/Map
objects being archived at CDS dump time (thanks Claes and Stuart M
This is a follow-up RFE of JDK-8201650 (Move iteration order randomization of
unmodifiable Set and Map to iterators), which was resolved to allow Set/Map
objects being archived at CDS dump time (thanks Claes and Stuart Marks). In the
current RFE, it archives the set of system ModuleReference and
11 matches
Mail list logo