On 07/03/2013 11:54, Staffan Larsen wrote:
Here is a webrev for fixing this problem. I actually removed all of our own
tokenization code in dll_build_name() and replaced it with calls to strtok_r
(strtok_s on windows) instead. I think this should be more robust, at the cost
of an extra memory
Can I get an official Review of this change?
Thanks,
/Staffan
On 7 mar 2013, at 12:54, Staffan Larsen staffan.lar...@oracle.com wrote:
Here is a webrev for fixing this problem. I actually removed all of our own
tokenization code in dll_build_name() and replaced it with calls to strtok_r
I already reviewed this, and it is a good fix.
Please, see my email attached.
Thanks,
Serguei
On 3/18/13 7:13 AM, Staffan Larsen wrote:
Can I get an official Review of this change?
Thanks,
/Staffan
On 7 mar 2013, at 12:54, Staffan Larsen staffan.lar...@oracle.com
Hi Serguei,
On 19/03/2013 2:47 AM, serguei.spit...@oracle.com wrote:
I already reviewed this, and it is a good fix.
Please, see my email attached.
You are not an OpenJDK Reviewer [1] . Staffan needs an official Review
from a Reviewer before it can be pushed. That doesn't mean your review
is
Here is a webrev for fixing this problem. I actually removed all of our own
tokenization code in dll_build_name() and replaced it with calls to strtok_r
(strtok_s on windows) instead. I think this should be more robust, at the cost
of an extra memory allocation. I've also added the const
Nice fix!
This is more clear and robust.
Extra memory allocation is Ok.
Thanks,
Serguei
On 3/7/13 3:54 AM, Staffan Larsen wrote:
Here is a webrev for fixing this problem. I actually removed all of
our own tokenization code in dll_build_name() and replaced it with
calls to strtok_r (strtok_s
Nice catch, Serguei!
Unfortunately I have already pushed my change, but I filed JDK-8009558:
linked_md.c::dll_build_name can get stuck in an infinite loop to track this
new problem and I am working on a fix.
Thanks,
/Staffan
On 5 mar 2013, at 20:26, serguei.spit...@oracle.com wrote:
Hi
Staffan,
Thank you for the confirmation and taking care about this issue!
Thanks,
Serguei
On 3/6/13 11:36 AM, Staffan Larsen wrote:
Nice catch, Serguei!
Unfortunately I have already pushed my change, but I filed
JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite
loop to
Thanks Alan!
On 5 mar 2013, at 15:19, Alan Bateman alan.bate...@oracle.com wrote:
On 04/03/2013 18:56, Staffan Larsen wrote:
I accidentally stepped on this bug the other day. There is a problem in
linker_md.c : dll_build_name() where an internal pointer can be moved to
point outside the
Hi Staffan,
Thank you for this discovery!
It looks good, but I have a couple of comments.
It seems, there is one more problem in this code:
68 /* check for NULL path */
69 if (p == pathname) {
70 continue;== Endless loop if we hit this line
71 }
Do
10 matches
Mail list logo
