Re: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

2020-03-03 Thread Martin Buchholz
#x27;t get the mails from Martin ☹ > > Cheers > Christoph > > > -Original Message- > > From: Volker Simonis > > Sent: Montag, 2. März 2020 16:17 > > To: Langer, Christoph > > Cc: Java Core Libs > > Subject: Re: RFR(s): 8240235: jdk.test.li

RE: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

2020-03-03 Thread Langer, Christoph
> On 03/03/20 12:45 pm, Langer, Christoph wrote: > > Unfortunately I don't get the mails from Martin ☹ > > Same for me. They always end up in spam folder which I usually check > once a month. I see that there's already > https://bugs.openjdk.java.net/browse/JDK-8213225 which seems to be the > same

Re: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

2020-03-03 Thread Jaikiran Pai
On 03/03/20 12:45 pm, Langer, Christoph wrote: > Unfortunately I don't get the mails from Martin ☹ Same for me. They always end up in spam folder which I usually check once a month. I see that there's already https://bugs.openjdk.java.net/browse/JDK-8213225 which seems to be the same issue. -Ja

Re: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

2020-03-02 Thread Martin Buchholz
On Mon, Mar 2, 2020 at 7:15 AM Volker Simonis wrote: > On Fri, Feb 28, 2020 at 8:02 PM Martin Buchholz > wrote: > > > > Welcome to the troublesome world of zip implementations! > > > > Well, not many remember that the zip format was designed to work > efficiently with floppy discs :) > > > It lo

Re: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

2020-02-28 Thread Martin Buchholz
Welcome to the troublesome world of zip implementations! It looks like by creating a new JarEntry you are discarding possible information from the old one, e.g. you might be discarding whether the input entry was compressed. If "jar u" does that, I would consider it a bug! Arguably there is a mi

RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

2020-02-28 Thread Volker Simonis
Hi, can I please have a review for this small test fix: http://cr.openjdk.java.net/~simonis/webrevs/2020/8240235/ https://bugs.openjdk.java.net/browse/JDK-8240235 JarUtils.updateJar() and JarUtils.updateJarFile() update jar files by reading JarEntry-s from a source jar file and writing these exa