Re: RFR: JDK-8073152: Update Standard/ExtendedCharsets to work with module system

2015-02-16 Thread Ulf Zibis
Am 16.02.2015 um 19:46 schrieb Xueming Shen: On 2/16/15 4:11 AM, Alan Bateman wrote: 2. Hasher.java is showing up in the webrev as a new file, was this build.tools.hasher.Hasher and so we know have two copies? "This" Hasher.java has a different use interface and works on a pair of key/value list

Re: RFR: JDK-8073152: Update Standard/ExtendedCharsets to work with module system

2015-02-16 Thread Alan Bateman
On 16/02/2015 18:46, Xueming Shen wrote: : 1. Is list_old needed, I can't tell if this is checked in for use by future archaeologists. No, it's not used by any code. I just added it the last minute to be a reference for the future, as I'm deleting the original list sbcs, dbcs and extsbcs.

Re: RFR: JDK-8073152: Update Standard/ExtendedCharsets to work with module system

2015-02-16 Thread Xueming Shen
On 2/16/15 4:11 AM, Alan Bateman wrote: On 14/02/2015 20:30, Xueming Shen wrote: Hi, Please help review the changes for JDK-8073152 Issue: https://bugs.openjdk.java.net/browse/JDK-8073152 Webrev: http://cr.openjdk.java.net/~sherman/8073152/webrev/ This change is to re-organize how the "stand

Re: RFR: JDK-8073152: Update Standard/ExtendedCharsets to work with module system

2015-02-16 Thread Alan Bateman
On 14/02/2015 20:30, Xueming Shen wrote: Hi, Please help review the changes for JDK-8073152 Issue: https://bugs.openjdk.java.net/browse/JDK-8073152 Webrev: http://cr.openjdk.java.net/~sherman/8073152/webrev/ This change is to re-organize how the "standard" and "extended" charsets repository

Re: RFR: JDK-8073152: Update Standard/ExtendedCharsets to work with module system

2015-02-16 Thread Erik Joelsson
(adding build-dev) Hello Sherman, In Gensrc-jdk.charsets.gmk: * The variable CHARSET_EXTENDED is defined but never used. The value is used in several places however. I think you should either use the variable or not define it at all. * $(CHARSET_EXTENDED_DATA) is put on a prerequisite line, bu

RFR: JDK-8073152: Update Standard/ExtendedCharsets to work with module system

2015-02-14 Thread Xueming Shen
Hi, Please help review the changes for JDK-8073152 Issue: https://bugs.openjdk.java.net/browse/JDK-8073152 Webrev: http://cr.openjdk.java.net/~sherman/8073152/webrev/ This change is to re-organize how the "standard" and "extended" charsets repository are built for the jdk/jre images. Before m