Hi,
I pushed this two days ago. Thank you Andrej for the contribution!
cheers
/Joel
On 9 sep 2014, at 11:21, Joel Borggrén-Franck joel.fra...@oracle.com wrote:
Hi Andrej,
Can you resend the latest patch attached to a mail to this list?
cheers
/Joel
On 2014-08-29, Andrej Golovnin
Hi Andrej,
Can you resend the latest patch attached to a mail to this list?
cheers
/Joel
On 2014-08-29, Andrej Golovnin wrote:
Hi Joel,
I have changed the test TestMethodReflectValueOf as you suggested and I
have changed the summary of both tests too. You will find the changes in
the
Hi Andrej,
On 22 jun 2014, at 00:00, Andrej Golovnin andrej.golov...@gmail.com wrote:
Hi Joel,
sorry for late response. I was too busy with other things.
Likewise!
I have changed the test TestMethodReflectValueOf as you suggested and I have
changed the summary of both tests too. You
Hi Joel,
I have changed the test TestMethodReflectValueOf as you suggested and I have
changed the summary of both tests too. You will find the changes in the
attached patch. Here is the new webrev: https://db.tt/wQBLVceA
And here is the coverage report in the HTML format:
Hi Joel,
First, thanks for contributing this. Lets start with some process, have you
signed the OCA?
Yes, you can find me here:
http://www.oracle.com/technetwork/community/oca-486395.html#g
I would say, It depends on how do you define matters. I personally
don't care
about the native
On 12 jun 2014, at 21:03, Andrej Golovnin andrej.golov...@gmail.com wrote:
That is why we have tests :) You will have an easier time getting this
accepted it you can show good code coverage of the fix in the current test
suite for example. See if you can get jcov [1] up and running with
Hi David, et.al.
I would let the compiler do auto-boxing where necessary. (Assuming
object identity is not necessary).
If type disambiguation is necessary then use a cast to the target type and
let the compiler do the rest. It keeps the source code simple and readable.
But I don't think it
Hi,
We need you send in the patches via the mailing list. Please reply to your mail
with the diffs attached directly (not zipped for example).
I’ll might have time to look at this next week, but it surprises me you need to
patch hotspot. Allocations before we have inflated shouldn’t be a
Hi Joel,
When you have for example following method:
public int method() {
return 0;
}
And you invoke this method over the reflection API,
then the first N invocations are done via the native code.
Yes, this is before inflation. Inflation happens after 15 calls IIRC, which
is why
Hi Andrej,
The hotspot changes need to be reviewed by hotspot developers so I've
cc'd the runtime team.
On 29/05/2014 8:45 PM, Andrej Golovnin wrote:
Hi Joel,
When you have for example following method:
public int method() {
return 0;
}
And you invoke this method over the reflection API,
Correction ...
On 29/05/2014 9:06 PM, David Holmes wrote:
Hi Andrej,
The hotspot changes need to be reviewed by hotspot developers so I've
cc'd the runtime team.
On 29/05/2014 8:45 PM, Andrej Golovnin wrote:
Hi Joel,
When you have for example following method:
public int method() {
return
Hi Joe,
I have prepared a patch for the issue JDK-5043030.
The patch consists of two parts: one for jdk and one for hotspot.
You can find the webrevs here:
JDK-patch: https://db.tt/7DYph0OH
Hotspot-patch: https://db.tt/hHsN0yn4
The JDK-patch has two tests to verify the changes.
Please review
12 matches
Mail list logo
