RFR: 8020779 & 8026988 : Improvements to JTReg executable location handling

2013-11-06 Thread Mike Duigou
Hello all; With JDK-8015068 only very recently pushed it's time for the next set of jtreg test/Makfile changes. These changes improve the configure script detection of jtreg and improve the handling of the specification variables in the jdk and langtools test/Makefiles. This changeset is also t

Re: RFR: 8020779 & 8026988 : Improvements to JTReg executable location handling

2013-11-07 Thread Erik Joelsson
Hello Mike, I think this looks good. A couple of comments that don't necessarily call for any changes. The version check is commented out, when is it planned to be activated? I see you use 'which' as a fallback in the makefiles. Just be aware that we have had some trouble using the which com

Re: RFR: 8020779 & 8026988 : Improvements to JTReg executable location handling

2013-11-07 Thread Mike Duigou
On Nov 7 2013, at 01:24 , Erik Joelsson wrote: > Hello Mike, > > I think this looks good. A couple of comments that don't necessarily call for > any changes. > > The version check is commented out, when is it planned to be activated? I was working on this piece at the same time as a the "mak

Re: RFR: 8020779 & 8026988 : Improvements to JTReg executable location handling

2013-11-07 Thread Magnus Ihse Bursie
On 2013-11-06 21:40, Mike Duigou wrote: Hello all; With JDK-8015068 only very recently pushed it's time for the next set of jtreg test/Makfile changes. These changes improve the configure script detection of jtreg and improve the handling of the specification variables in the jdk and langtool