Re: RFR 8054213: Class name repeated in output of Type.toString()

Thank you, Joe! Sure, I'll change alignment in the test. Thanks, Svetlana On 15.07.2016 8:56, joe darcy wrote: Hi Svetlana, Looks okay. I approve pushing the fix with the following change to the test: have the expected output align with the given output. The webrev shows 63

Re: RFR 8054213: Class name repeated in output of Type.toString()

Hi Svetlana, Looks okay. I approve pushing the fix with the following change to the test: have the expected output align with the given output. The webrev shows 63 "FirstInnerClassGeneric$SecondInnerClassGeneric") 64 public FirstInnerClassGeneric.SecondInnerClassGeneric

Re: RFR 8054213: Class name repeated in output of Type.toString()

Kindly reminder. On 07.07.2016 18:49, Svetlana Nikandrova wrote: Hello all, seems like Joe is busy right now, so meanwhile I'll be happy to hear other opinions on this topic. Thank you, Svetlana On 30.06.2016 19:44, Svetlana Nikandrova wrote: Hello Joe, thank you for your advice!

Re: RFR 8054213: Class name repeated in output of Type.toString()

Hello all, seems like Joe is busy right now, so meanwhile I'll be happy to hear other opinions on this topic. Thank you, Svetlana On 30.06.2016 19:44, Svetlana Nikandrova wrote: Hello Joe, thank you for your advice! GenericStringTest looks really good with annotations. I refactored my

Re: RFR 8054213: Class name repeated in output of Type.toString()

Joe, I'll be glad to know your opinion. Thank you, Svetlana - Исходное сообщение - От: svetlana.nikandr...@oracle.com Кому: joe.da...@oracle.com Копия: core-libs-dev@openjdk.java.net Отправленные: Четверг, 30 Июнь 2016 г 19:45:24 GMT +03:00 Ирак Тема: Re: RFR 8054213: Class name

Re: RFR 8054213: Class name repeated in output of Type.toString()

Hello Joe, thank you for your advice! GenericStringTest looks really good with annotations. I refactored my test, please see updated webrev: http://cr.openjdk.java.net/~snikandrova/8054213/webrev.01/ As for "." vs "$" let me

Re: RFR 8054213: Class name repeated in output of Type.toString()

Hello Svetlana, I'm not convinced '$' should be replaced with '.' in this context as '.' is what the separator used in source code. In any case, the test should be restructured. I recommend declaring an annotation type to hold the expected to string output. You can them loop over the

Re: RFR 8054213: Class name repeated in output of Type.toString()

May be someone can find a minute? On 27.06.2016 21:25, Svetlana Nikandrova wrote: Kindly reminder On 24.06.2016 14:58, Svetlana Nikandrova wrote: Hello, let me try again with updated version of webrev: Webrev: http://cr.openjdk.java.net/~snikandrova/8054213/webrev.01/

Re: RFR 8054213: Class name repeated in output of Type.toString()

Kindly reminder On 24.06.2016 14:58, Svetlana Nikandrova wrote: Hello, let me try again with updated version of webrev: Webrev: http://cr.openjdk.java.net/~snikandrova/8054213/webrev.01/ Issue:

Re: RFR 8054213: Class name repeated in output of Type.toString()

Hello, let me try again with updated version of webrev: Webrev: http://cr.openjdk.java.net/~snikandrova/8054213/webrev.01/ Issue: https://bugs.openjdk.java.net/browse/JDK-8054213 Many thanks goes to Sergey Ustimenko for his

RFR: 8054213: Class name repeated in output of Type.toString()

Hi all, bug https://bugs.openjdk.java.net/browse/JDK-8054213 This fix modifies behavior of Type.to String() to conform with JLS 13.1 paragraph 1 and also JVMS 4.2.1. For now in case of parametrized types inner type name consists of normal binary name of immediately enclosing type, followed by $

[PATCH] RFR: 8054213: Class name repeated in output of Type.toString()

Forgot to attach a patch 2016-03-17 15:13 GMT+03:00 Sergey Ustimenko : > Hi all, > > bug https://bugs.openjdk.java.net/browse/JDK-8054213 > > This fix modifies behavior of Type.to String() to conform with JLS 13.1 > paragraph 1 > and also JVMS 4.2.1. For now in case of

Re: RFR: 8054213: Class name repeated in output of Type.toString()

Hi all, bug https://bugs.openjdk.java.net/browse/JDK-8054213 I have reworked previous patch to conform with JLS 13.1 paragraph 1 and also JVMS 4.2.1. For now in case of parametrized types inner type name consists of normal binary name of immediately enclosing type, followed by $, followed by

RFR: 8054213: Class name repeated in output of Type.toString()

Hi all, Please review this patch. I'm also looking for sponsor for this one. The unexpected duplication of owner type was produced by Method.toString() for static classes and interfaces. Problem is fixed by slightly changing the way of obtaining simple name of static nested type and