Re: RFR: 8059570, Addition of tests for RowSetFactory and RowSetProvider

2014-10-02 Thread Lance Andersen
Hi Daniel, Thank you for you review. On Oct 2, 2014, at 6:39 AM, Daniel Fuchs wrote: > Hi Lance, > > I probably don't know enough about rowset to qualify as reviewer > for this change, but I had a look at the tests - and I believe > they look good. Thank you. > I wonder whether there should

Re: RFR: 8059570, Addition of tests for RowSetFactory and RowSetProvider

2014-10-02 Thread Daniel Fuchs
Hi Lance, I probably don't know enough about rowset to qualify as reviewer for this change, but I had a look at the tests - and I believe they look good. I wonder whether there should be some additional tests that would run with a security manager on? The only thing unusual I noticed is that the

RFR: 8059570, Addition of tests for RowSetFactory and RowSetProvider

2014-10-01 Thread Lance Andersen
Hi all, Looking for a reviewer for the unit tests being added for RowSetFactory and RowSetProvider. The webrev can be found at http://cr.openjdk.java.net/~lancea/8059570/webrev.00/ Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 N