Re: RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

2016-05-17 Thread Alan Bateman
On 15/05/2016 19:54, Xueming Shen wrote: Thanks Alan, Here is the webrev with the first proposed change. http://cr.openjdk.java.net/~sherman/8147588/webrev/ -sherman It needs a bit of clean-up but I think we can live with the approach. One thing that could be cleaned up is to move the loadi

Re: RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

2016-05-15 Thread Xueming Shen
Thanks Alan, Here is the webrev with the first proposed change. http://cr.openjdk.java.net/~sherman/8147588/webrev/ -sherman On 5/14/2016 1:01 PM, Alan Bateman wrote: On 13/05/2016 22:09, Xueming Shen wrote: My memory suggests the reason we went to winFileHandleOpen() is for that windows'

Re: RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

2016-05-14 Thread Alan Bateman
On 13/05/2016 22:09, Xueming Shen wrote: My memory suggests the reason we went to winFileHandleOpen() is for that windows' long path issue we dealt with years ago. ZFILE_Open() does not appear to deal with that. Sure I can bring ZFILE_Open in for the non-windows platform, though my original

Re: RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

2016-05-13 Thread Xueming Shen
On 5/13/16 1:24 PM, Alan Bateman wrote: On 13/05/2016 19:49, Xueming Shen wrote: something like this? http://cr.openjdk.java.net/~sherman/8147588/webrev/ Along these lines, yes. Would it be cleaner if ZipFile_openAndDelete were rename to ZipFile_open and used ZFILE_Open in libzip instead o

Re: RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

2016-05-13 Thread Alan Bateman
On 13/05/2016 19:49, Xueming Shen wrote: something like this? http://cr.openjdk.java.net/~sherman/8147588/webrev/ Along these lines, yes. Would it be cleaner if ZipFile_openAndDelete were rename to ZipFile_open and used ZFILE_Open in libzip instead of winFileHandleOpen in libjava? Also giv

Re: RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

2016-05-13 Thread Xueming Shen
On 5/13/16 3:27 AM, Alan Bateman wrote: On 12/05/2016 20:16, Xueming Shen wrote: Hi, Please help review the proposed change for #8147588 issue: https://bugs.openjdk.java.net/browse/JDK-8147588 webrev: http://cr.openjdk.java.net/~sherman/8147588/webrev This is a regression on Windows platform

Re: RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

2016-05-13 Thread Alan Bateman
On 12/05/2016 20:16, Xueming Shen wrote: Hi, Please help review the proposed change for #8147588 issue: https://bugs.openjdk.java.net/browse/JDK-8147588 webrev: http://cr.openjdk.java.net/~sherman/8147588/webrev This is a regression on Windows platform triggered by the change for https://bugs.

RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

2016-05-12 Thread Xueming Shen
Hi, Please help review the proposed change for #8147588 issue: https://bugs.openjdk.java.net/browse/JDK-8147588 webrev: http://cr.openjdk.java.net/~sherman/8147588/webrev This is a regression on Windows platform triggered by the change for https://bugs.openjdk.java.net/browse/JDK-8145260, in wh