Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 [v2]

2021-04-05 Thread Jim Laskey
> We should never close the jimage since java threads can still be running > after a hard exit(). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Remove dead code - Changes: - all:

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-03 Thread Jim Laskey
I’ll remove the code and elucidate in the commentary.  > On Apr 3, 2021, at 8:08 PM, David Holmes wrote: > > On 4/04/2021 12:02 am, Jim Laskey wrote: >> Is it in bad form to declare a #define CLOSE_JIMAGE 0 ? > > Still dead code. > > This is a core-libs style call anyway. > > Cheers, >

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-03 Thread David Holmes
On 4/04/2021 12:02 am, Jim Laskey wrote: Is it in bad form to declare a #define CLOSE_JIMAGE 0 ? Still dead code. This is a core-libs style call anyway. Cheers, David  On Apr 3, 2021, at 9:49 AM, David Holmes wrote: On 2/04/2021 5:34 pm, Alan Bateman wrote: On Thu, 1 Apr 2021

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-03 Thread Jim Laskey
Is it in bad form to declare a #define CLOSE_JIMAGE 0 ?  > On Apr 3, 2021, at 9:49 AM, David Holmes wrote: > > On 2/04/2021 5:34 pm, Alan Bateman wrote: >> On Thu, 1 Apr 2021 18:48:15 GMT, Jim Laskey wrote: src/java.base/share/native/libjimage/imageFile.cpp line 219: > 217:

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-03 Thread David Holmes
On 2/04/2021 5:34 pm, Alan Bateman wrote: On Thu, 1 Apr 2021 18:48:15 GMT, Jim Laskey wrote: src/java.base/share/native/libjimage/imageFile.cpp line 219: 217: // WARNING: Should never close the jimage file. 218: // Threads may still be running at shutdown. 219: #if 0 Are you

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-02 Thread Alan Bateman
On Thu, 1 Apr 2021 18:48:15 GMT, Jim Laskey wrote: >> src/java.base/share/native/libjimage/imageFile.cpp line 219: >> >>> 217: // WARNING: Should never close the jimage file. >>> 218: // Threads may still be running at shutdown. >>> 219: #if 0 >> >> Are you keeping the code in order

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-02 Thread Alan Bateman
On Thu, 1 Apr 2021 11:48:21 GMT, Jim Laskey wrote: > We should never close the jimage since java threads can still be running > after a hard exit(). Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3304

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-01 Thread Jim Laskey
On Thu, 1 Apr 2021 18:19:35 GMT, Alan Bateman wrote: >> We should never close the jimage since java threads can still be running >> after a hard exit(). > > src/java.base/share/native/libjimage/imageFile.cpp line 219: > >> 217: // WARNING: Should never close the jimage file. >> 218: //

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-01 Thread Alan Bateman
On Thu, 1 Apr 2021 11:48:21 GMT, Jim Laskey wrote: > We should never close the jimage since java threads can still be running > after a hard exit(). src/java.base/share/native/libjimage/imageFile.cpp line 219: > 217: // WARNING: Should never close the jimage file. > 218: // Threads

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-01 Thread Ioi Lam
On Thu, 1 Apr 2021 11:48:21 GMT, Jim Laskey wrote: > We should never close the jimage since java threads can still be running > after a hard exit(). LGTM. - Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3304

RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-01 Thread Jim Laskey
We should never close the jimage since java threads can still be running after a hard exit(). - Commit messages: - 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 Changes: https://git.openjdk.java.net/jdk/pull/3304/files Webrev: