> We should never close the jimage since java threads can still be running
> after a hard exit().
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Remove dead code
-
Changes:
- all:
I’ll remove the code and elucidate in the commentary.
> On Apr 3, 2021, at 8:08 PM, David Holmes wrote:
>
> On 4/04/2021 12:02 am, Jim Laskey wrote:
>> Is it in bad form to declare a #define CLOSE_JIMAGE 0 ?
>
> Still dead code.
>
> This is a core-libs style call anyway.
>
> Cheers,
>
On 4/04/2021 12:02 am, Jim Laskey wrote:
Is it in bad form to declare a #define CLOSE_JIMAGE 0 ?
Still dead code.
This is a core-libs style call anyway.
Cheers,
David
On Apr 3, 2021, at 9:49 AM, David Holmes wrote:
On 2/04/2021 5:34 pm, Alan Bateman wrote:
On Thu, 1 Apr 2021
Is it in bad form to declare a #define CLOSE_JIMAGE 0 ?
> On Apr 3, 2021, at 9:49 AM, David Holmes wrote:
>
> On 2/04/2021 5:34 pm, Alan Bateman wrote:
>> On Thu, 1 Apr 2021 18:48:15 GMT, Jim Laskey wrote:
src/java.base/share/native/libjimage/imageFile.cpp line 219:
> 217:
On 2/04/2021 5:34 pm, Alan Bateman wrote:
On Thu, 1 Apr 2021 18:48:15 GMT, Jim Laskey wrote:
src/java.base/share/native/libjimage/imageFile.cpp line 219:
217: // WARNING: Should never close the jimage file.
218: // Threads may still be running at shutdown.
219: #if 0
Are you
On Thu, 1 Apr 2021 18:48:15 GMT, Jim Laskey wrote:
>> src/java.base/share/native/libjimage/imageFile.cpp line 219:
>>
>>> 217: // WARNING: Should never close the jimage file.
>>> 218: // Threads may still be running at shutdown.
>>> 219: #if 0
>>
>> Are you keeping the code in order
On Thu, 1 Apr 2021 11:48:21 GMT, Jim Laskey wrote:
> We should never close the jimage since java threads can still be running
> after a hard exit().
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3304
On Thu, 1 Apr 2021 18:19:35 GMT, Alan Bateman wrote:
>> We should never close the jimage since java threads can still be running
>> after a hard exit().
>
> src/java.base/share/native/libjimage/imageFile.cpp line 219:
>
>> 217: // WARNING: Should never close the jimage file.
>> 218: //
On Thu, 1 Apr 2021 11:48:21 GMT, Jim Laskey wrote:
> We should never close the jimage since java threads can still be running
> after a hard exit().
src/java.base/share/native/libjimage/imageFile.cpp line 219:
> 217: // WARNING: Should never close the jimage file.
> 218: // Threads
On Thu, 1 Apr 2021 11:48:21 GMT, Jim Laskey wrote:
> We should never close the jimage since java threads can still be running
> after a hard exit().
LGTM.
-
Marked as reviewed by iklam (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3304
We should never close the jimage since java threads can still be running after
a hard exit().
-
Commit messages:
- 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28
Changes: https://git.openjdk.java.net/jdk/pull/3304/files
Webrev:
11 matches
Mail list logo