Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-04-01 Thread Brian Burkhalter
> On Apr 1, 2019, at 6:03 PM, Mandy Chung wrote: > > On 4/1/19 5:22 PM, Lance Andersen wrote: >> A follow-up on this. >> >> I ran this test 300+ times without failure on the internal Mach 5 machines >> including the one that it failed on (which was only 4 times since January). >> This one

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-04-01 Thread Mandy Chung
On 4/1/19 5:22 PM, Lance Andersen wrote:  A follow-up on this. I ran this test 300+ times without failure on the internal Mach 5 machines including the one that it failed on (which was only 4 times since January).  This one system would run the test in approximately 6-7 minutes on average

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-04-01 Thread Lance Andersen
A follow-up on this. I ran this test 300+ times without failure on the internal Mach 5 machines including the one that it failed on (which was only 4 times since January). This one system would run the test in approximately 6-7 minutes on average where as the the other window systems were run

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-03-28 Thread Mandy Chung
On 3/28/19 12:19 AM, Alan Bateman wrote: On 28/03/2019 00:23, Mandy Chung wrote: On 3/27/19 4:56 PM, Lance Andersen wrote: Hi Mandy, On Mar 27, 2019, at 7:23 PM, Mandy Chung > wrote: Hi Lance, Do you understand what takes so long for this test to run?

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-03-28 Thread Alan Bateman
On 28/03/2019 00:23, Mandy Chung wrote: On 3/27/19 4:56 PM, Lance Andersen wrote: Hi Mandy, On Mar 27, 2019, at 7:23 PM, Mandy Chung > wrote: Hi Lance, Do you understand what takes so long for this test to run? Well it is executing a lot of jar commands.  

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-03-27 Thread Mandy Chung
On 3/27/19 4:56 PM, Lance Andersen wrote: Hi Mandy, On Mar 27, 2019, at 7:23 PM, Mandy Chung > wrote: Hi Lance, Do you understand what takes so long for this test to run? Well it is executing a lot of jar commands.  I did not see anything that sticks out

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-03-27 Thread Lance Andersen
Hi Mandy, > On Mar 27, 2019, at 7:23 PM, Mandy Chung wrote: > > Hi Lance, > > Do you understand what takes so long for this test to run? Well it is executing a lot of jar commands. I did not see anything that sticks out in the failed logs that point to anything obvious. > Is it running fast

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-03-27 Thread Joe Darcy
Hello, I agree it would be preferable to understand why the test times out rather than just upping its timeout value. Thanks, -Joe On 3/27/2019 4:23 PM, Mandy Chung wrote: Hi Lance, Do you understand what takes so long for this test to run? Is it running fastdebug and -Xcomp or other flag?

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-03-27 Thread Mandy Chung
Hi Lance, Do you understand what takes so long for this test to run? Is it running fastdebug and -Xcomp or other flag? Mandy On 3/27/19 1:55 PM, Lance Andersen wrote: Hi all , Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8216539 which increases the timeout value for th

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-03-27 Thread Brian Burkhalter
Seems reasonable. [1] Brian > On Mar 27, 2019, at 1:55 PM, Lance Andersen wrote: > > Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8216539 > which increases the > timeout value for this test which fails once in a blue mo

RFR: 8216539: tools/jar/modularJar/Basic.java timed out

2019-03-27 Thread Lance Andersen
Hi all , Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8216539 which increases the timeout value for this test which fails once in a blue moon on windows. ——— $ hg diff diff -r dc66ada06693 test/jdk/tools/jar/modularJar/Basic.java --- a/test/jdk/tools/jar/modularJar/B