Re: RFR: 8230302: GenerateJLIClassesPlugin can generate invalid DirectMethodHandle methods

2019-08-28 Thread Claes Redestad
Hi Mandy, On 2019-08-28 19:11, Mandy Chung wrote: On 8/28/19 7:38 AM, Claes Redestad wrote: Hi, we currently spin code for a non-sensical invokeVirtual DMH, so let's remove that. Such methods are benign since we won't ever attempt to resolve such nonsensical forms, but surely a waste of

Re: RFR: 8230302: GenerateJLIClassesPlugin can generate invalid DirectMethodHandle methods

2019-08-28 Thread Mandy Chung
On 8/28/19 7:38 AM, Claes Redestad wrote: Hi, we currently spin code for a non-sensical invokeVirtual DMH, so let's remove that. Such methods are benign since we won't ever attempt to resolve such nonsensical forms, but surely a waste of space. This patch tightens checks conservatively

RFR: 8230302: GenerateJLIClassesPlugin can generate invalid DirectMethodHandle methods

2019-08-28 Thread Claes Redestad
Hi, we currently spin code for a non-sensical invokeVirtual DMH, so let's remove that. Such methods are benign since we won't ever attempt to resolve such nonsensical forms, but surely a waste of space. This patch tightens checks conservatively (could possibly apply the same restriction to