Re: RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

2020-01-17 Thread li . jiang
Hi Naoto, Thank you for reviewing. The eol characters were removed by t9n system, if I correct the format manually the next time we run the msg drop it would be back. Considering we need to kick off the next msg drop soon, I prefer not to fix it this time. Regards, Leo On 1/18/20 2:31 AM,

Re: RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

2020-01-17 Thread Joe Wang
On 1/17/20 10:31 AM, naoto.s...@oracle.com wrote: Hi Leo, The l10n files for HelpResources_*.properties in jpackage discard the format in the original English resource file where lines are nicely aligned. Can you please preserve the format? Also, I find it odd to observe duplicated

Re: RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

2020-01-17 Thread naoto . sato
Hi Leo, The l10n files for HelpResources_*.properties in jpackage discard the format in the original English resource file where lines are nicely aligned. Can you please preserve the format? Also, I find it odd to observe duplicated String literals in every XPATHErrorResources_*.java files.

RFR: 8237465: JDK 14 L10N resource files update - msg drop 10

2020-01-17 Thread li . jiang
Hi, Please review the L10N resource files update for JDK 14 msg drop 10. https://bugs.openjdk.java.net/browse/JDK-8237465 http://cr.openjdk.java.net/~ljiang/8237465/webrev/read/ This is the first msg drop for JDK 14 L10N resources files update, so this webrev would cover most of update for