Re: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-04-22 Thread Roger Riggs
e" > To: Adam Farley8 > Cc: core-libs-dev , Roger Riggs > > Date: 21/04/2020 18:29 > Subject: [EXTERNAL] Re: RFR: 8239365: ProcessBuilder/Basic.java test > modifications for AIX execution > > Hi Adam, > > I do not have strong emotions, leave it up to you. But did you

Re: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-04-22 Thread Thomas Stüfe
t; > So long as it passes when it should pass, and fails only when it should > > fail, clarity is a "would be nice", but ultimately a secondary priority. > > > > Thanks for your feedback. :) > > > > Best Regards > > > > Adam Farley > > IBM

RE: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-04-22 Thread Adam Farley8
; Thanks for your feedback. :) > > Best Regards > > Adam Farley > IBM Runtimes > > > "Thomas Stüfe" wrote on 03/03/2020 10:52:10: > > > From: "Thomas Stüfe" > > To: Adam Farley8 > > Cc: core-libs-dev > > Date: 03/03/20

Re: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-04-21 Thread Roger Riggs
that much either way. Thanks for your feedback. :) Best Regards Adam Farley IBM Runtimes "Thomas Stüfe" wrote on 03/03/2020 10:52:10: From: "Thomas Stüfe" To: Adam Farley8 Cc: core-libs-dev Date: 03/03/2020 10:52 Subject: [EXTERNAL] Re: RFR: 8239365: ProcessBuilder/Bas

Re: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-04-21 Thread Thomas Stüfe
03/03/2020 10:52:10: > > > From: "Thomas Stüfe" > > To: Adam Farley8 > > Cc: core-libs-dev > > Date: 03/03/2020 10:52 > > Subject: [EXTERNAL] Re: RFR: 8239365: ProcessBuilder/Basic.java test > > modifications for AIX execution > > > >

RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-04-21 Thread Adam Farley8
Thanks for your feedback. :) Best Regards Adam Farley IBM Runtimes "Thomas Stüfe" wrote on 03/03/2020 10:52:10: > From: "Thomas Stüfe" > To: Adam Farley8 > Cc: core-libs-dev > Date: 03/03/2020 10:52 > Subject: [EXTERNAL] Re: RFR: 8239365: ProcessBu

RE: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-03-05 Thread Adam Farley8
Stüfe" > To: Adam Farley8 > Cc: core-libs-dev > Date: 03/03/2020 10:52 > Subject: [EXTERNAL] Re: RFR: 8239365: ProcessBuilder/Basic.java test > modifications for AIX execution > > This is why I always was against handing up the result of strerror > to the user :)

Re: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-03-03 Thread Roger Riggs
Hi Adam, It doesn't look like you saw my comments from 2/21. Please take another look. http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-February/064878.html Roger On 3/3/20 5:43 AM, Adam Farley8 wrote: Hi All, Reviews and sponsor requested for a small test change. Short version: W

Re: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-03-03 Thread Thomas Stüfe
This is why I always was against handing up the result of strerror to the user :) The same problem we would have when running with different locales. We should have a platform agnostic string table in the java lib for that purpose... As for the test, looks good, but I personally would shorten the

RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

2020-03-03 Thread Adam Farley8
Hi All, Reviews and sponsor requested for a small test change. Short version: When an AIX machine has the file set "bos.msg.en_US.rte", the error messages are not in a form that the test expects, causing failure. The simplest option appears to be adding the second potential form of the messag