Looks good, Claes.
Just one small question:
src/java.base/share/classes/java/util/jar/JarFile.java
759 } catch (IOException | IllegalArgumentException ex) {
Why the addition of IllegalArgumentException ?
-Brent
On 5/10/20 2:07 PM, Claes Redestad wrote:
Hi Martin,
On 2020-05-10 21
Looks good to me!
On Sun, May 10, 2020 at 2:07 PM Claes Redestad
wrote:
> Hi Martin,
>
> On 2020-05-10 21:53, Martin Buchholz wrote:
> > Thanks for improving the jar/zip code.
>
> thanks!
>
> > I wish I had more time to do the same.
> > My own superficial review only adds one small suggestion:
>
Hi Martin,
On 2020-05-10 21:53, Martin Buchholz wrote:
Thanks for improving the jar/zip code.
thanks!
I wish I had more time to do the same.
My own superficial review only adds one small suggestion:
add a comment as to why isSignatureRelated never hits a negative index
exception.
Yes, it's
Thanks for improving the jar/zip code.
I wish I had more time to do the same.
My own superficial review only adds one small suggestion:
add a comment as to why isSignatureRelated never hits a negative index
exception.
I still like my ancient "ASCII trick" comment.
On Thu, May 7, 2020 at 2:34 PM Cl
Hi Claes,
I think this looks good. One suggestion before you finalize and push, perhaps
update the comment in ZipFile
// Use the "oldest ASCII trick in the book"
—
to include something that this is for lowercase comparison. It just might help
others when they look at the code and d
I updated open.01 with a reworked microbenchmark that uses
JarFile.getInputStream to trigger the "maybe instantiate
the JAR verifier" logic.
This exercise the code being optimized in this patch better,
while also being a little bit more realistic. Improvements around
1.3x-1.5x across tested jar v
Hi Max,
On 2020-05-08 09:08, Weijun Wang wrote:
JarFile.java:
734: extra new line?
Fixed
930: Remove or rewrite the comment.
Did even better: now that I find the position of the manifest during
initCEN, this method should always call JUZFA.getManifest(this, false);
- which is both a simpl
JarFile.java:
734: extra new line?
930: Remove or rewrite the comment.
ZipFile.java:
49: seems not used
Please add links to each other between
src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java::isBlockOrSF
and
src/java.base/share/classes/java/util/zip/ZipFile.java::isS
Hi,
currently during ZipFile creation, we create an int[] array of pointers
to META-INF entries. These are then retrieved from three different
places in JarFile.
However, JarFile is only interested in some combination a few things:
the existence of and name of the META-INF/MANIFEST file, the exi
