On Sun, 13 Sep 2020 02:22:54 GMT, Jaikiran Pai wrote:
>> Hi Jaikiran,
>>
>> The change seems fine an inline with the RFC. I can sponsor this once we
>> have another review.
>>
>> I have run the JCK tests for Zip/Gzip/Jar and Mach5 JDK tier1, tier2 and
>> tier3
>
> Thank you Lance for the rev
> Can I please get a review and a sponsor for this patch which fixes the issue
> reported in
> https://bugs.openjdk.java.net/browse/JDK-8244706?
> The commit here sets the `OS` header flag to `255` (which represents
> `unknown`) as noted in [1]. A new test has been
> included in this commit to ve
On Tue, 15 Sep 2020 12:39:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for this patch which fixes the issue
>> reported in
>> https://bugs.openjdk.java.net/browse/JDK-8244706?
>> The commit here sets the `OS` header flag to `255` (which represents
>> `unknown`) as note
On Tue, 15 Sep 2020 12:39:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for this patch which fixes the issue
>> reported in
>> https://bugs.openjdk.java.net/browse/JDK-8244706?
>> The commit here sets the `OS` header flag to `255` (which represents
>> `unknown`) as note
On Tue, 15 Sep 2020 16:54:29 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unintended file commit
>
> Thank you for making the changes that Brent and I suggested. This looks
> good.