Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-20 Thread Brian Burkhalter
On Fri, 20 Nov 2020 11:43:11 GMT, sergus13 wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8246739: InputStream.skipNBytes could be implemented more efficiently >> - 8246739: InputStream.skipNBytes could be

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-20 Thread sergus13
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-20 Thread sergus13
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-20 Thread sergus13
On Fri, 20 Nov 2020 09:56:16 GMT, sergus13 wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8246739: InputStream.skipNBytes could be implemented more efficiently >> - 8246739: InputStream.skipNBytes could be

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-19 Thread Naoto Sato
On Thu, 19 Nov 2020 21:41:00 GMT, Naoto Sato wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8246739: InputStream.skipNBytes could be implemented more efficiently >> - 8246739: InputStream.skipNBytes could b

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-19 Thread Naoto Sato
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-19 Thread Lance Andersen
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-19 Thread Roger Riggs
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-19 Thread Brian Burkhalter
> Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once > and, if not enough bytes have been skipped, then `read()` is