Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v5]

2021-07-23 Thread Pavel Rappo
On Tue, 2 Mar 2021 18:07:24 GMT, Stuart Marks wrote: >> test/jdk/jdk/internal/util/ArraysSupport/NewLength.java line 100: >> >>> 98: int r = ArraysSupport.newLength(old, min, pref); >>> 99: fail("expected OutOfMemoryError, got normal return value of >>> " + r); >>> 100:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v5]

2021-03-02 Thread Stuart Marks
On Tue, 2 Mar 2021 15:05:51 GMT, Pavel Rappo wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year. > > src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 579: > >> 577: /**

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v5]

2021-03-02 Thread Pavel Rappo
On Tue, 2 Mar 2021 06:29:07 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v5]

2021-03-02 Thread Roger Riggs
On Tue, 2 Mar 2021 06:29:07 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v5]

2021-03-01 Thread Stuart Marks
> This rewrites the doc of ArraysSupport.newLength, adds detail to the > exception message, and adds a test. In addition to some renaming and a bit of > refactoring of the actual code, I also made two changes of substance to the > code: > > 1. I fixed a problem with overflow checking. In the or