Re: RFR: 8249867: xml declaration is not followed by a newline [v2]

2021-01-27 Thread Joe Wang
On Wed, 27 Jan 2021 15:41:02 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update: add javadoc for impl specific features and properties in >> module-info; update the patch accordingly. > > src/java

Re: RFR: 8249867: xml declaration is not followed by a newline [v2]

2021-01-27 Thread Joe Wang
On Wed, 27 Jan 2021 15:34:26 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update: add javadoc for impl specific features and properties in >> module-info; update the patch accordingly. > > src/java

Re: RFR: 8249867: xml declaration is not followed by a newline [v2]

2021-01-27 Thread Joe Wang
On Wed, 27 Jan 2021 11:39:29 GMT, Lance Andersen wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update: add javadoc for impl specific features and properties in >> module-info; update the patch accordingly. > > src/j

Re: RFR: 8249867: xml declaration is not followed by a newline [v2]

2021-01-27 Thread Naoto Sato
On Wed, 27 Jan 2021 06:33:01 GMT, Joe Wang wrote: >> Please review a patch to add an explicit control over whether a newline >> should be added after the XML header. This is done by adding a DOM >> LSSerializer property "jdk-is-standalone" and System property >> "jdk.xml.isStandalone". >> >>

Re: RFR: 8249867: xml declaration is not followed by a newline [v2]

2021-01-27 Thread Roger Riggs
On Wed, 27 Jan 2021 06:33:01 GMT, Joe Wang wrote: >> Please review a patch to add an explicit control over whether a newline >> should be added after the XML header. This is done by adding a DOM >> LSSerializer property "jdk-is-standalone" and System property >> "jdk.xml.isStandalone". >> >>

Re: RFR: 8249867: xml declaration is not followed by a newline [v2]

2021-01-27 Thread Lance Andersen
On Wed, 27 Jan 2021 06:33:01 GMT, Joe Wang wrote: >> Please review a patch to add an explicit control over whether a newline >> should be added after the XML header. This is done by adding a DOM >> LSSerializer property "jdk-is-standalone" and System property >> "jdk.xml.isStandalone". >> >>

Re: RFR: 8249867: xml declaration is not followed by a newline [v2]

2021-01-26 Thread Joe Wang
> Please review a patch to add an explicit control over whether a newline > should be added after the XML header. This is done by adding a DOM > LSSerializer property "jdk-is-standalone" and System property > "jdk.xml.isStandalone". > > This change addresses an incompatibility introduced durin