Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final)

2020-10-19 Thread Vicente Romero
On Thu, 8 Oct 2020 11:49:17 GMT, Jan Lahoda wrote: > This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current specificatio

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final)

2020-10-20 Thread Jan Lahoda
On Tue, 20 Oct 2020 03:02:03 GMT, Vicente Romero wrote: >> This is the current proposed patch for the upcoming JEP 394, for pattern >> matching for instanceof. >> >> A summary of changes: >> -making the feature permanent (non-preview) >> -making the binding variables non-final (as per current s

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final)

2020-10-20 Thread Jan Lahoda
On Tue, 20 Oct 2020 03:09:27 GMT, Vicente Romero wrote: >> This is the current proposed patch for the upcoming JEP 394, for pattern >> matching for instanceof. >> >> A summary of changes: >> -making the feature permanent (non-preview) >> -making the binding variables non-final (as per current s

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v2]

2020-10-20 Thread Vicente Romero
On Tue, 20 Oct 2020 12:03:39 GMT, Jan Lahoda wrote: >> This is the current proposed patch for the upcoming JEP 394, for pattern >> matching for instanceof. >> >> A summary of changes: >> -making the feature permanent (non-preview) >> -making the binding variables non-final (as per current speci

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v2]

2020-10-20 Thread Vicente Romero
On Tue, 20 Oct 2020 12:03:39 GMT, Jan Lahoda wrote: >> This is the current proposed patch for the upcoming JEP 394, for pattern >> matching for instanceof. >> >> A summary of changes: >> -making the feature permanent (non-preview) >> -making the binding variables non-final (as per current speci

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v2]

2020-10-20 Thread Vicente Romero
On Tue, 20 Oct 2020 11:36:41 GMT, Jan Lahoda wrote: >> test/langtools/tools/javac/patterns/LocalVariableTable.java line 29: >> >>> 27: * @summary Ensure the LV table entries are generated for bindings >>> 28: * @modules jdk.jdeps/com.sun.tools.classfile >>> 29: * @compile -g LocalVariableTabl

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v2]

2020-10-21 Thread Jan Lahoda
> This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current specification > proposal) > -producing a compile-time error for

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v2]

2020-10-21 Thread Jan Lahoda
On Wed, 21 Oct 2020 03:26:57 GMT, Vicente Romero wrote: >> I believe plain jtreg invocations may not be always setting "-g". So >> probably better to be explicitly clear we need -g, as the test itself >> requires the debugging info/LocalVariableTable? > > sure I understand that the `-g` option

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v2]

2020-10-21 Thread Jan Lahoda
On Wed, 21 Oct 2020 03:11:28 GMT, Vicente Romero wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 15 additional >> commits s

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v3]

2020-10-21 Thread Jan Lahoda
> This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current specification > proposal) > -producing a compile-time error for

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v2]

2020-10-22 Thread Jan Lahoda
On Wed, 21 Oct 2020 03:12:08 GMT, Vicente Romero wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 15 additional >> commits s

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v2]

2020-10-22 Thread Jan Lahoda
On Wed, 21 Oct 2020 03:13:34 GMT, Vicente Romero wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 15 additional >> commits s

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v4]

2020-10-22 Thread Jan Lahoda
> This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current specification > proposal) > -producing a compile-time error for

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v4]

2020-10-23 Thread Vicente Romero
On Thu, 22 Oct 2020 12:14:42 GMT, Jan Lahoda wrote: >> This is the current proposed patch for the upcoming JEP 394, for pattern >> matching for instanceof. >> >> A summary of changes: >> -making the feature permanent (non-preview) >> -making the binding variables non-final (as per current speci

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v5]

2020-10-29 Thread Jan Lahoda
> This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current specification > proposal) > -producing a compile-time error for

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v6]

2020-11-04 Thread Jan Lahoda
> This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current specification > proposal) > -producing a compile-time error for