On Tue, 23 Feb 2021 12:10:30 GMT, Evan Whelan wrote:
>> Does the new version of the test still occasionally catches the issue and
>> fails if the fix is not present?
>
> Hi, locally this test reproduces the issue on my Windows machine.
>
> I believe our internal testing Windows boxes are too
On Tue, 23 Feb 2021 10:16:26 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> I've removed the problematic "process" handling logic and have stripped the
>> test back to only use threads.
>>
>> The problem was reproducible (intermittently on my Windows machine) using
>> this smaller test and should
On Mon, 22 Feb 2021 09:46:56 GMT, Evan Whelan wrote:
>> I'm seeing some intermittent test failures with the new test (after merging
>> in latest master changes). Can you retest and have a look:
>>
>> --System.out:(25/1343)--
>> Testing with arguments: type=process, count=20
>>
On Fri, 19 Feb 2021 14:06:23 GMT, Daniel Fuchs wrote:
>> LGTM
>
> I'm seeing some intermittent test failures with the new test (after merging
> in latest master changes). Can you retest and have a look:
>
> --System.out:(25/1343)--
> Testing with arguments: type=process,
On Thu, 18 Feb 2021 10:41:17 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Added IllegalArgumentException for incorrect usage
>
> LGTM
I'm seeing some intermittent test failures with
On Wed, 17 Feb 2021 14:47:03 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review this fix for JDK-8252883. This handles the case when an
>> AccessDeniedException is being thrown on Windows, due to a delay in deleting
>> the lock file it is trying to write to.
>>
>> This fix passes all
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Evan Whelan has updated the pull
