On Fri, 12 Feb 2021 23:40:51 GMT, Brian Burkhalter wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.java.net/browse/JDK-8260401?
>>
>> As noted in that issue, when the constructor of
>> `java.util.prefs.WindowsPreferences`
On Fri, 12 Feb 2021 03:34:54 GMT, Jaikiran Pai wrote:
>> Did you run this through the usual CI tests in all tiers?
>
>> Did you run this through the usual CI tests in all tiers?
>
> Hello Brian,
>
> Do you mean other than the ones that have been automatically run and passed
> in the GitHub act
On Sat, 30 Jan 2021 14:35:50 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8260401?
>
> As noted in that issue, when the constructor of
> `java.util.prefs.WindowsPreferences` runs into
On Fri, 12 Feb 2021 03:21:04 GMT, Brian Burkhalter wrote:
> Did you run this through the usual CI tests in all tiers?
Hello Brian,
Do you mean other than the ones that have been automatically run and passed in
the GitHub actions against this PR? I don't have a Windows box, but if there's
some
On Fri, 12 Feb 2021 03:16:02 GMT, Jaikiran Pai wrote:
>> I'd let it sit for a bit in case others want to comment.
>
> Ping. Anymore reviews/suggestions from anyone?
Did you run this through the usual CI tests in all tiers?
-
PR: https://git.openjdk.java.net/jdk/pull/2326
On Tue, 2 Feb 2021 02:41:10 GMT, Brian Burkhalter wrote:
>>> > The code change looks all right.
>>>
>>> Should I go ahead and integrate this?
>>
>> Actually, I didn't notice that this PR wasn't marked as reviewed. I'll wait
>> for the review(s) then.
>
> I'd let it sit for a bit in case others
On Tue, 2 Feb 2021 02:31:09 GMT, Jaikiran Pai wrote:
>> Hello Brian,
>>
>> Thank you for the review.
>>
>>> It would be better if there were a test, but apparently this might depend
>>> on the user who runs the test not having registry access rights.
>>
>> That's correct. Looking at the code,
On Tue, 2 Feb 2021 02:25:04 GMT, Jaikiran Pai wrote:
> > The code change looks all right.
>
> Should I go ahead and integrate this?
Actually, I didn't notice that this PR wasn't marked as reviewed. I'll wait for
the review(s) then.
-
PR: https://git.openjdk.java.net/jdk/pull/2326
On Mon, 1 Feb 2021 19:21:23 GMT, Brian Burkhalter wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.java.net/browse/JDK-8260401?
>>
>> As noted in that issue, when the constructor of
>> `java.util.prefs.WindowsPreferences` r
On Sat, 30 Jan 2021 14:35:50 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8260401?
>
> As noted in that issue, when the constructor of
> `java.util.prefs.WindowsPreferences` runs into
Can I please get a review for this change which proposes to fix the issue
reported in https://bugs.openjdk.java.net/browse/JDK-8260401?
As noted in that issue, when the constructor of
`java.util.prefs.WindowsPreferences` runs into an error while dealing with the
Windows registry, it logs a warn
11 matches
Mail list logo
