RFR: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702

2021-02-15 Thread Christoph Langer
After the fix for JDK-8253702, the test java/lang/System/OsVersionTest.java still fails on BigSur versions that have a patch version (> 1), e.g. on macOS Big Sur 11.2.1, and where the JDK was built with xcode < 12. java.lang.Error: 11.2 != 11.2.1 This is a proposal to relax the test and throw a

Re: RFR: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702

2021-02-15 Thread Christoph Langer
On Mon, 15 Feb 2021 13:27:36 GMT, Christoph Langer wrote: > After the fix for JDK-8253702, the test java/lang/System/OsVersionTest.java > still fails on BigSur versions that have a patch version (> 1), e.g. on macOS > Big Sur 11.2.1, and where the JDK was built with xcode < 12. > > java.lang.E

Re: RFR: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702

2021-02-15 Thread Roger Riggs
On Mon, 15 Feb 2021 13:40:26 GMT, Christoph Langer wrote: >> After the fix for JDK-8253702, the test java/lang/System/OsVersionTest.java >> still fails on BigSur versions that have a patch version (> 1), e.g. on >> macOS Big Sur 11.2.1, and where the JDK was built with xcode < 12. >> >> java.l

Re: RFR: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702

2021-02-15 Thread Christoph Langer
On Mon, 15 Feb 2021 14:06:31 GMT, Roger Riggs wrote: > Given the lack of veracity from the os... > Perhaps check that `swVersion.startsWith(osVersion) == true` (if the whole > string doesn't match). > > I'm hopeful that when JDK 17 is released the toolchain has been upgraded and > this patch w

Re: RFR: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702 [v2]

2021-02-15 Thread Christoph Langer
> After the fix for JDK-8253702, the test java/lang/System/OsVersionTest.java > still fails on BigSur versions that have a patch version (> 1), e.g. on macOS > Big Sur 11.2.1, and where the JDK was built with xcode < 12. > > java.lang.Error: 11.2 != 11.2.1 > > This is a proposal to relax the te

Re: RFR: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702 [v2]

2021-02-15 Thread Roger Riggs
On Mon, 15 Feb 2021 15:07:55 GMT, Christoph Langer wrote: >> After the fix for JDK-8253702, the test java/lang/System/OsVersionTest.java >> still fails on BigSur versions that have a patch version (> 1), e.g. on >> macOS Big Sur 11.2.1, and where the JDK was built with xcode < 12. >> >> java.l

Re: RFR: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702 [v3]

2021-02-16 Thread Christoph Langer
> After the fix for JDK-8253702, the test java/lang/System/OsVersionTest.java > still fails on BigSur versions that have a patch version (> 1), e.g. on macOS > Big Sur 11.2.1, and where the JDK was built with xcode < 12. > > java.lang.Error: 11.2 != 11.2.1 > > This is a proposal to relax the te