Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation [v2]

2021-03-30 Thread Attila Szegedi
On Tue, 30 Mar 2021 12:43:18 GMT, Athijegannathan Sundararajan wrote: >> Attila Szegedi has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contai

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation [v2]

2021-03-30 Thread Athijegannathan Sundararajan
On Sun, 28 Mar 2021 13:38:51 GMT, Attila Szegedi wrote: >> I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods >> had a lot of code duplication among themselves, and even within each method. >> I refactored them into a modern unified implementation. While there I also >>

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation [v2]

2021-03-28 Thread Attila Szegedi
> I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods > had a lot of code duplication among themselves, and even within each method. > I refactored them into a modern unified implementation. While there I also > took the opportunity to introduce `Objects.requireNonNull` in

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation [v2]

2021-03-28 Thread Attila Szegedi
On Sat, 27 Mar 2021 15:46:36 GMT, Alan Bateman wrote: >> Attila Szegedi has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains 13 new >> com

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation

2021-03-27 Thread Alan Bateman
On Sat, 27 Mar 2021 15:19:37 GMT, Attila Szegedi wrote: > I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods > had a lot of code duplication among themselves, and even within each method. > I refactored them into a modern unified implementation. While there I also > too

RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation

2021-03-27 Thread Attila Szegedi
I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods had a lot of code duplication among themselves, and even within each method. I refactored them into a modern unified implementation. While there I also took the opportunity to introduce `Objects.requireNonNull` in place o

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation

2021-03-27 Thread Attila Szegedi
On Sat, 27 Mar 2021 15:19:37 GMT, Attila Szegedi wrote: > I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods > had a lot of code duplication among themselves, and even within each method. > I refactored them into a modern unified implementation. While there I also > too