Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

2022-01-14 Thread Masanori Yano
On Sat, 8 Jan 2022 16:09:59 GMT, Lance Andersen wrote: >> Masanori Yano has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8272746: ZipFile can't open big file (NegativeArraySizeException) > > Thank you for your work here. Have you also

Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

2022-01-08 Thread Lance Andersen
On Fri, 24 Dec 2021 11:07:04 GMT, Masanori Yano wrote: >> Could you please review the JDK-8272746 bug fixes? >> Since the array index is of type int, the overflow occurs when the value of >> end.cenlen is too large because of too many entries. >> It is necessary to read a part of the CEN from

Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

2022-01-06 Thread Lance Andersen
On Thu, 6 Jan 2022 09:34:24 GMT, Alan Bateman wrote: > > @AlanBateman Could you please review the above comments. > > Thanks for changing the message, the update to ZipFile looks good to me > although I'm still surprised that the native tools support a CEN larger than > 2Gb. > > I'm slow to

Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

2022-01-06 Thread Alan Bateman
On Thu, 23 Dec 2021 16:42:50 GMT, Alan Bateman wrote: >> Masanori Yano has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8272746: ZipFile can't open big file (NegativeArraySizeException) > >

Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

2022-01-05 Thread Masanori Yano
On Thu, 23 Dec 2021 16:42:50 GMT, Alan Bateman wrote: >> Masanori Yano has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8272746: ZipFile can't open big file (NegativeArraySizeException) > >

Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

2021-12-24 Thread Masanori Yano
On Thu, 23 Dec 2021 16:42:50 GMT, Alan Bateman wrote: >> Masanori Yano has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8272746: ZipFile can't open big file (NegativeArraySizeException) > >

Re: RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v2]

2021-12-24 Thread Masanori Yano
> Could you please review the JDK-8272746 bug fixes? > Since the array index is of type int, the overflow occurs when the value of > end.cenlen is too large because of too many entries. > It is necessary to read a part of the CEN from the file to fix the problem > fundamentally, but the way will