Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v24]

2022-03-03 Thread XenoAmess
> 8281631: HashMap copy constructor and putAll can over-allocate table XenoAmess has updated the pull request incrementally with one additional commit since the last revision: cast several float to double before calculation - Changes: - all: https://git.openjdk.java.net/jdk/pul

Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v24]

2022-03-03 Thread Stuart Marks
On Thu, 3 Mar 2022 15:46:37 GMT, XenoAmess wrote: >> 8281631: HashMap copy constructor and putAll can over-allocate table > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > cast several float to double before calculation src/jav

Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v24]

2022-03-03 Thread Stuart Marks
On Thu, 3 Mar 2022 15:46:37 GMT, XenoAmess wrote: >> 8281631: HashMap copy constructor and putAll can over-allocate table > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > cast several float to double before calculation OK, I t

Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v24]

2022-03-04 Thread XenoAmess
On Fri, 4 Mar 2022 02:27:53 GMT, Stuart Marks wrote: > OK, I took a look at HashMapsPutAllOverAllocateTableTest.java. It's certainly > a good start at testing stuff in this area. However, I notice that > > ``` > test/jdk/java/util/HashMap/WhiteBoxResizeTest.java > ``` > > already exists and te

Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v24]

2022-03-04 Thread XenoAmess
On Fri, 4 Mar 2022 02:27:53 GMT, Stuart Marks wrote: >> XenoAmess has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cast several float to double before calculation > > OK, I took a look at HashMapsPutAllOverAllocateTableTest.java. It's cer

Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v24]

2022-03-04 Thread XenoAmess
On Thu, 3 Mar 2022 15:46:37 GMT, XenoAmess wrote: >> 8281631: HashMap copy constructor and putAll can over-allocate table > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > cast several float to double before calculation I would