GCC 12 reports as following:
-
Commit messages:
- 8286694: Incorrect argument processing in java launcher
Changes: https://git.openjdk.java.net/jdk/pull/8694/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8694&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
Simply considering the compiler warning shouldn't `(arg+2) == NULL` actually be
`arg[2] = '\0'` ? as we are looking to see if this arg is only three
characters: '-', 'J' and '\0'
-
PR: https:
On Mon, 16 May 2022 06:58:22 GMT, David Holmes wrote:
> Simply considering the compiler warning shouldn't `(arg+2) == NULL` actually
> be `arg[2] == '\0'` ? as we are looking to see if this arg is only three
> characters: '-', 'J' and '\0'
Yeah, I thought that first, but I think better of keep
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
I don't recall what "builtin arguments" means. Can you tell me how we would
actually hit this conditions such that we string dup and the null string? Or
are you saying this is actually an unreachable case
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
src/java.base/share/native/libjli/java.c line 1632:
> 1630: if (JLI_IsTraceLauncher()) {
> 1631: printf("Empty option: jargv[%d]\n", i);
> 1632: }
I'd sa
On Mon, 16 May 2022 13:20:49 GMT, David Holmes wrote:
>> GCC 12 reports as following:
>
> I don't recall what "builtin arguments" means. Can you tell me how we would
> actually hit this conditions such that we string dup and the null string? Or
> are you saying this is actually an unreachable
On Fri, 13 May 2022 08:56:59 GMT, Yasumasa Suenaga wrote:
> GCC 12 reports as following:
You forced me to look at this in depth. The values are set via the build
system. In the build system it is impossible to get just -J because the -J is
only added as a prefix for an existing string. So basi
On Tue, 17 May 2022 04:39:06 GMT, David Holmes wrote:
>> GCC 12 reports as following:
>
> You forced me to look at this in depth. The values are set via the build
> system. In the build system it is impossible to get just -J because the -J is
> only added as a prefix for an existing string. So
On Tue, 17 May 2022 13:54:59 GMT, Yasumasa Suenaga wrote:
>> You forced me to look at this in depth. The values are set via the build
>> system. In the build system it is impossible to get just -J because the -J
>> is only added as a prefix for an existing string. So basically this is
>> impos
> GCC 12 reports as following:
Yasumasa Suenaga has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three additional
commits since the last revision:
- U
On Tue, 17 May 2022 13:55:43 GMT, Yasumasa Suenaga wrote:
>> GCC 12 reports as following:
>
> Yasumasa Suenaga has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull reque
On Wed, 18 May 2022 06:12:41 GMT, David Holmes wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
On Wed, 18 May 2022 07:40:43 GMT, Thomas Stuefe wrote:
>> src/java.base/share/native/libjli/java.c line 1631:
>>
>>> 1629: const char *arg = jargv[i];
>>> 1630: if (arg[0] == '-' && arg[1] == 'J') {
>>> 1631: assert(arg[2] != '\0' && "Invalid JAVA_ARGS or
>>> EXTRA_J
13 matches
Mail list logo
