On 03/06/2015 02:30 PM, Staffan Larsen wrote:
I would like to backport this bug fix to jdk8 - does anyone see any problems
with that? The patch applies cleanly (after shuffling) and the
java/lang/invoke/ tests succeed.
Thanks,
/Staffan
I see no problem, quite the opposite, please backport
I would like to backport this bug fix to jdk8 - does anyone see any problems
with that? The patch applies cleanly (after shuffling) and the
java/lang/invoke/ tests succeed.
Thanks,
/Staffan
1. Are there other places where we generate ACC_SYNTHETIC that should
also get @Hidden annotations?
Compiler-generated bridge methods?
On 02/17/2015 07:54 AM, John Rose wrote:
On Feb 16, 2015, at 10:33 PM, Staffan Larsen staffan.lar...@oracle.com wrote:
The first shot at fixing this bug was to filter out ACC_SYNTHETIC. The drawback
was that the actual lambda method are marked ACC_SYNTHETIC, so that filtered
too much.
OTOH
+1
cheers
/Joel
On 16 Feb 2015, at 15:25, Staffan Larsen staffan.lar...@oracle.com wrote:
Good point!
new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/
Thanks,
/Staffan
On 16 feb 2015, at 12:40, Remi Forax fo...@univ-mlv.fr wrote:
Hi Staffan,
ASM MethodVisitor API
yes,
thumb up !
Rémi
Le 16 février 2015 18:50:25 CET, Joel Borggrén-Franck
joel.fra...@oracle.com a écrit :
+1
cheers
/Joel
On 16 Feb 2015, at 15:25, Staffan Larsen staffan.lar...@oracle.com
wrote:
Good point!
new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/
Thanks,
On Feb 16, 2015, at 6:25 AM, Staffan Larsen staffan.lar...@oracle.com wrote:
new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/
http://cr.openjdk.java.net/~sla/8025636/webrev.02/
Looks good; ship it.
To me this fix raises more questions:
1. Are there other places where we
Good point!
new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/
http://cr.openjdk.java.net/~sla/8025636/webrev.02/
Thanks,
/Staffan
On 16 feb 2015, at 12:40, Remi Forax fo...@univ-mlv.fr wrote:
Hi Staffan,
ASM MethodVisitor API requires to call visitAnnotation before calling
On 17 feb 2015, at 02:16, John Rose john.r.r...@oracle.com wrote:
On Feb 16, 2015, at 6:25 AM, Staffan Larsen staffan.lar...@oracle.com
mailto:staffan.lar...@oracle.com wrote:
new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/
On Feb 16, 2015, at 10:33 PM, Staffan Larsen staffan.lar...@oracle.com wrote:
The first shot at fixing this bug was to filter out ACC_SYNTHETIC. The
drawback was that the actual lambda method are marked ACC_SYNTHETIC, so that
filtered too much.
OTOH it seems odd to filter out the actual
Looks good.
Best regards,
Vladimir Ivanov
On 2/16/15 10:47 AM, Staffan Larsen wrote:
Brian pointed out to me that this change missed to add the annotation to bridge
methods. Here is an updated version that takes those into account. I also
needed to update the test to verify that bridge
Brian pointed out to me that this change missed to add the annotation to bridge
methods. Here is an updated version that takes those into account. I also
needed to update the test to verify that bridge methods were correctly
annotated - it got a little bit more complex since I had to force
Hi,
On 03 Feb 2015, at 10:15, Staffan Larsen staffan.lar...@oracle.com wrote:
Hi,
Please review this patch for hiding the lambda proxy frame in stack traces:
bug: https://bugs.openjdk.java.net/browse/JDK-8025636
webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.00/
This is a
Hi,
Please review this patch for hiding the lambda proxy frame in stack traces:
bug: https://bugs.openjdk.java.net/browse/JDK-8025636
https://bugs.openjdk.java.net/browse/JDK-8025636
webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.00/
http://cr.openjdk.java.net/~sla/8025636/webrev.00/
Looks good for me.
Rémi
Le 3 février 2015 10:15:24 CET, Staffan Larsen staffan.lar...@oracle.com a
écrit :
Hi,
Please review this patch for hiding the lambda proxy frame in stack
traces:
bug: https://bugs.openjdk.java.net/browse/JDK-8025636
https://bugs.openjdk.java.net/browse/JDK-8025636
15 matches
Mail list logo
