Hi All,
Please review the simple fix for JNI pending exceptions in
FileSystemPreferences.c. Thanks!
Bug: https://bugs.openjdk.java.net/browse/JDK-8028726
Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev/
-Dan
Dan,
Looks OK, but line 914 which you did not change, notice the comments not sure
if that is common in this code but seemed a bit off to me:
914 //// If at first, you don't succeed...
On Jan 6, 2014, at 5:29 PM, Dan Xu wrote:
> Hi All,
>
> Please review the simple fix for JNI
Hi Lance,
Thanks for your review.
My understanding towards the for loop in lockFile() of
FileSystemPreferences.java is that it retries if anything fails. So I
don't touch L914 to keep its old logic un-changed. Please let me know if
you have some good suggestions. Thanks!
-Dan
On 01/06/201
H Dan,
No comments on the logic, but the comment format seemed a bit strange to me
(notice the extra '//')
Best
Lance
On Jan 6, 2014, at 6:07 PM, Dan Xu wrote:
> Hi Lance,
>
> Thanks for your review.
>
> My understanding towards the for loop in lockFile() of
> FileSystemPreferences.java is
On 6 Jan 2014, at 22:29, Dan Xu wrote:
> Hi All,
>
> Please review the simple fix for JNI pending exceptions in
> FileSystemPreferences.c. Thanks!
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8028726
> Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev/
Looks good to me Dan.
Trivial
On 06/01/2014 22:29, Dan Xu wrote:
Hi All,
Please review the simple fix for JNI pending exceptions in
FileSystemPreferences.c. Thanks!
Bug: https://bugs.openjdk.java.net/browse/JDK-8028726
Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev/
The update to FIleSystemPreferences.c looks okay
Hi All,
Thanks for your good review. I have dropped the change in
FileSystemPreferences.java , and created the new webrev which only
changes FileSystemPreferences.c. Please help review it. Thanks!
Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev.01/
When changing FileSystemPreferences.
On 08/01/2014 00:50, Dan Xu wrote:
Hi All,
Thanks for your good review. I have dropped the change in
FileSystemPreferences.java , and created the new webrev which only
changes FileSystemPreferences.c. Please help review it. Thanks!
Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev.01/
Thank you, Alan. I will add this change into my fix and push it today.
Thanks!
-Dan
On 01/08/2014 01:24 AM, Alan Bateman wrote:
On 08/01/2014 00:50, Dan Xu wrote:
Hi All,
Thanks for your good review. I have dropped the change in
FileSystemPreferences.java , and created the new webrev which
Hi Alan,
Btw, I am wondering whether I need pass a variable to see if the
returned char* is a copy or not, and basing on that to do the release.
For example,
jboolean isCopy;
const char *fname = JNU_GetStringPlatformChars(env, java_fname,
&isCopy);
if (isCopy == JNI_TRUE)
JNU_ReleaseStri
On 08/01/2014 18:48, Dan Xu wrote:
Hi Alan,
Btw, I am wondering whether I need pass a variable to see if the
returned char* is a copy or not, and basing on that to do the release.
For example,
jboolean isCopy;
const char *fname = JNU_GetStringPlatformChars(env, java_fname, &isCopy);
if (isCo
11 matches
Mail list logo
