Re: RFR: JDK-8079063 ZoneOffsetTransition constructor should ignore nanoseconds

2015-05-06 Thread Roger Riggs
Hi Peter, Thanks for the analysis and followup. Yes, I think thesimple check as you propose is the desired clarification. I agree that the change should not affect any existing code outside the JDK and does not raise a compatibility issue. Roger On 5/4/2015 6:22 AM, Peter Levart wrote: Hi,

Re: RFR: JDK-8079063 ZoneOffsetTransition constructor should ignore nanoseconds

2015-05-06 Thread Stephen Colebourne
I am also happy with this change. Stephen On 6 May 2015 at 15:43, Roger Riggs roger.ri...@oracle.com wrote: Hi Peter, Thanks for the analysis and followup. Yes, I think thesimple check as you propose is the desired clarification. I agree that the change should not affect any existing code

Re: RFR: JDK-8079063 ZoneOffsetTransition constructor should ignore nanoseconds

2015-05-06 Thread Peter Levart
Cool! Do we need any CCC approval as this *is* a spec change isn't it? I haven't done such a thing yet, so please give me some pointers. I also intend to add a jtreg test that verifies this new behavior. Regards, Peter On 05/06/2015 05:06 PM, Stephen Colebourne wrote: I am also happy with

Re: RFR: JDK-8079063 ZoneOffsetTransition constructor should ignore nanoseconds

2015-05-06 Thread Roger Riggs
Hi Peter, I'll run the CCC side, mostly it follows the similar rationale and structure as the jira entry. And the details are in your webrev. Thanks, Roger On 5/6/2015 11:43 AM, Peter Levart wrote: Cool! Do we need any CCC approval as this *is* a spec change isn't it? I haven't done such

RFR: JDK-8079063 ZoneOffsetTransition constructor should ignore nanoseconds

2015-05-04 Thread Peter Levart
Hi, Now that JDK-8074003 is in, I'd like to discuss how to tackle JDK-8079063. Package-private ZoneOffsetTransition constructor that takes LocalDateTime transition is invoked from the following 4 places: 1 - the public static factory method: /** * Obtains an instance defining a