looks good.
/Andy
On 3/25/2019 6:35 PM, Alexander Matveev wrote:
Hi Andy,
http://cr.openjdk.java.net/~almatvee/8215019/webrev.01/
Updated webrev with added missing message in
HelpResources_zh_CN.properties and updated messages below:
MSG_Help_win_install_dir=\
\Relative sub-path under the
Hi Andy,
http://cr.openjdk.java.net/~almatvee/8215019/webrev.01/
Updated webrev with added missing message in
HelpResources_zh_CN.properties and updated messages below:
MSG_Help_win_install_dir=\
\Relative sub-path under the default installation location\n\
I think you missed HelpResources_zh_CN.properties
I think wording of help text: 'sub-path of the installation location of
the application such as"Program Files" or "AppData"' is misleading. It
reads like "Program files" or "AppDAta" are examples of the sub-path.
The error message says:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Added support for --install-dir on Windows. It should be relative path
to "Program Files" or "AppData".
- If --install-dir is invalid we will use
