Re: RFR: JDK-8221333: Replace Inno Setup with custom MSI wrapper for .exe bundler

2019-06-14 Thread Alexander Matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/14/2019 10:09 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Get rid of dependency on Inno Setup for .exe installers on

Re: RFR: JDK-8221333: Replace Inno Setup with custom MSI wrapper for .exe bundler

2019-06-14 Thread Alexey Semenyuk
Andy, Thank you for the review! - Alexey On 6/14/2019 4:29 PM, Andy Herrick wrote: On 6/14/19, 3:45 PM, Andy Herrick wrote: I imported this patch , and after some merging problems, built jpackager. a simple exe installer built with: $JDK_HOME/bin/jpackage create-installer \

Re: RFR: JDK-8221333: Replace Inno Setup with custom MSI wrapper for .exe bundler

2019-06-14 Thread Andy Herrick
On 6/14/19, 3:45 PM, Andy Herrick wrote: I imported this patch , and after some merging problems, built jpackager. a simple exe installer built with: $JDK_HOME/bin/jpackage create-installer \ --installer-type exe \ --input ../input-jars \ --output output \ --name test-exe \ --vendor

Re: RFR: JDK-8221333: Replace Inno Setup with custom MSI wrapper for .exe bundler

2019-06-14 Thread Andy Herrick
I imported this patch , and after some merging problems, built jpackager. a simple exe installer built with: $JDK_HOME/bin/jpackage create-installer \ --installer-type exe \ --input ../input-jars \ --output output \ --name test-exe \ --vendor "Oracle Test" \ --description "Test exe installer"

RFR: JDK-8221333: Replace Inno Setup with custom MSI wrapper for .exe bundler

2019-06-14 Thread Alexey Semenyuk
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Get rid of dependency on Inno Setup for .exe installers on Windows platform. [1] https://bugs.openjdk.java.net/browse/JDK-8221333 [2]