Re: RFR: JDK-8224222: Inno setup 6 broke jpackage

2019-05-20 Thread Alexey Semenyuk
Alexander, I tried running other .exe from ISS install dir. They don't output anything meaningful. File version for all .exe files in ISS install dir is "0.0.0.0". Running isscc.exe without arguments doesn't output version number. Running isscc.exe with the empty project file was the only

Re: RFR: JDK-8224222: Inno setup 6 broke jpackage

2019-05-20 Thread Alexander Matveev
Hi Alexey, Is there better way to figure out InnoSetup version? Creating empty project file seems complicated. If there no such way, then fix looks fine. Thanks, Alexander On 5/20/2019 8:27 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the

RFR: JDK-8224222: Inno setup 6 broke jpackage

2019-05-20 Thread Alexey Semenyuk
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Improve code detecting version of Inno Setup to make it work with Inno Setup v6 updates. [1] https://bugs.openjdk.java.net/browse/JDK-8224222 [2]