On 6/20/2019 1:44 PM, Kevin Rushforth wrote:
Looks good. I presume you will update the HelpResources.properties for
other languages before you push?
yes - they are updated - I just left them out of the file list.
/Andy
-- Kevin
On 6/20/2019 9:54 AM, Andy Herrick wrote:
On 6/19/2019 1:34
Looks good. I presume you will update the HelpResources.properties for
other languages before you push?
-- Kevin
On 6/20/2019 9:54 AM, Andy Herrick wrote:
On 6/19/2019 1:34 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch br
Looks good.
- Alexey
On 6/20/2019 12:54 PM, Andy Herrick wrote:
On 6/19/2019 1:34 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8225428: CLI change to remove "mode",
On 6/19/2019 1:34 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8225428: CLI change to remove "mode", rename to "package", and
build only one target
[1] https://bugs.
On 6/19/2019 6:26 PM, Alexander Matveev wrote:
Hi Andy,
1) Looks like you forgot to update HelpResources_ja.properties and
HelpResources_zh_CN.properties.
Yes I need to re-run my script to update these.
2)
http://cr.openjdk.java.net/~herrick/8225428/webrev.01/src/jdk.jpackage/share/class
Hi Andy,
1) Looks like you forgot to update HelpResources_ja.properties and
HelpResources_zh_CN.properties.
2)
http://cr.openjdk.java.net/~herrick/8225428/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html
Line 84: Error: creating ap
On 6/19/2019 2:08 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~herrick/8225428/webrev.01/test/jdk/tools/jpackage/JPackageMissingArgumentsTest.java.sdiff.html:
---
private static final String [] RESULT_7 = {"--module-path",
"--runtime-image", "app-image"};
---
Should it be "--app-
http://cr.openjdk.java.net/~herrick/8225428/webrev.01/test/jdk/tools/jpackage/JPackageMissingArgumentsTest.java.sdiff.html:
---
private static final String [] RESULT_7 = {"--module-path",
"--runtime-image", "app-image"};
---
Should it be "--app-image"?
- Alexey
On 6/19/2019 1:34 PM, Andy Herri
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8225428: CLI change to remove "mode", rename to "package", and build
only one target
[1] https://bugs.openjdk.java.net/browse/JDK-8225428
[2] ht
