Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-06 Thread Alan Bateman
On 06/11/2019 16:35, Michael Paus wrote: I still don't see how entries like this java.desktop provides javax.sound.midi.spi.MidiDeviceProvider used by java.desktop I assume you have this line in the output: java.desktop provides java.net.ContentHandlerFactory used by java.base java.desktop,

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-06 Thread Michael Paus
Am 06.11.19 um 16:32 schrieb Alan Bateman: On 06/11/2019 14:01, Michael Paus wrote: The --suggest-providers option would be more useful if one could limit it to the providers that can actually be used by my code, i.e. a call like jlink --add-modules java.base --suggest-providers should only

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-06 Thread Alan Bateman
On 06/11/2019 14:01, Michael Paus wrote: The --suggest-providers option would be more useful if one could limit it to the providers that can actually be used by my code, i.e. a call like jlink --add-modules java.base --suggest-providers should only return the providers which can be reached b

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-06 Thread Michael Paus
Am 06.11.19 um 14:07 schrieb Alan Bateman: On 06/11/2019 12:24, Michael Paus wrote: But this is also a very dangerous option because it may place time-bombs into your packaged applications. For example, I recently realized that I could not make any https-requests any more in my packaged applic

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-06 Thread Alan Bateman
On 06/11/2019 12:24, Michael Paus wrote: But this is also a very dangerous option because it may place time-bombs into your packaged applications. For example, I recently realized that I could not make any https-requests any more in my packaged application. To fix that I had to explicitly add "

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-06 Thread Michael Paus
ime errors. -- Michael Message: 2 Date: Wed, 6 Nov 2019 05:18:15 +0100 From: Kevin Rushforth To: Philip Race , Andy Herrick Cc: core-libs-dev Subject: Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink Message-ID: <58a2d94b-6de5-baed-8427-fa6a5b821.

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-05 Thread Kevin Rushforth
Yes, this is a good change. +1 -- Kevin On 11/6/2019 2:02 AM, Philip Race wrote: I noticed this problem when creating various demo scenarios so +1 to the change, but +\  Pass on --bind-seervices option to jlink (which will link in \n\ typo here -phil On 11/5/19, 3:36 PM, Andy He

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-05 Thread Alexander Matveev
Hi Andy, http://cr.openjdk.java.net/~herrick/8233594/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties.frames.html  106 \  Pass on --bind-seervices option to jlink (which will link in \n\ Spelling: --bind-seervices -> --bind-services Oth

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-05 Thread Philip Race
I noticed this problem when creating various demo scenarios so +1 to the change, but +\ Pass on --bind-seervices option to jlink (which will link in \n\ typo here -phil On 11/5/19, 3:36 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the

Re: RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-05 Thread Alexey Semenyuk
Looks good. - Alexey On 11/5/2019 6:36 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This changes adds the --bind-services option and removes the previous behavior of alw

RFR: JDK-8233594: create a new option --bind-servces to pass on to jlink

2019-11-05 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This changes adds the --bind-services option and removes the previous behavior of always including --bind-services in the jlink options except when --