Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

2020-11-23 Thread Alexander Zuev
On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8256475: Fix Behavior when Installer name differs from application name. Looks good. src/jdk.jpackage/s

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

2020-11-21 Thread Andy Herrick
On Thu, 19 Nov 2020 23:32:22 GMT, Alexander Matveev wrote: >> Andy Herrick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8256475: Fix Behavior when Installer name differs from application >> name. > > Marked as reviewed by almatv

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

2020-11-19 Thread Alexander Matveev
On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8256475: Fix Behavior when Installer name differs from application name. Marked as reviewed by almatvee

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

2020-11-19 Thread Alexey Semenyuk
On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8256475: Fix Behavior when Installer name differs from application name. Marked as reviewed by asemenyuk

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]

2020-11-19 Thread Andy Herrick
> …n name. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8256475: Fix Behavior when Installer name differs from application name. - Changes: - all: https://git.openjdk.java.net/jdk/pull/1300/files - new: https:

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v3]

2020-11-19 Thread Andy Herrick
> …n name. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8256475: Fix Behavior when Installer name differs from application name. - Changes: - all: https://git.openjdk.java.net/jdk/pull/1300/files - new: https:

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v2]

2020-11-19 Thread Alexey Semenyuk
On Thu, 19 Nov 2020 16:49:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 69 additional >

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v2]

2020-11-19 Thread Andy Herrick
> …n name. Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 69 additional commits since the last revision: - JDK-8256475: Fix Behavior wh

Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio…

2020-11-18 Thread Alexander Matveev
On Wed, 18 Nov 2020 22:17:07 GMT, Andy Herrick wrote: > …n name. src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java line 312: > 310: Path appDir; > 311: if (appName == null) { > 312: // this can only happen when no name is given and using > f

RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio…

2020-11-18 Thread Andy Herrick
…n name. - Commit messages: - JDK-8256475: Fix Behavior when Installer name differs from application name. Changes: https://git.openjdk.java.net/jdk/pull/1300/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1300&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK