On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2030
On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2030
On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
Marked as reviewed by asemenyuk (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2030
On Wed, 13 Jan 2021 13:14:17 GMT, Andy Herrick wrote:
>> I agree is better to have the check in windows specific code (not Platform)
>> and will move it.
>> The "os.arch" System property in 32 java is "x86" regardless of whether
>> running on 64 or 32 bit version of Windows, It reflects the ar
On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
-
PR: https://git.openjdk.java.net/jdk/pull/2030
On Wed, 13 Jan 2021 13:11:12 GMT, Andy Herrick wrote:
>> Sorry, I left this comment earlier, but it was lost.
>
> I agree is better to have the check in windows specific code (not Platform)
> and will move it.
> The "os.arch" System property in 32 java is "x86" regardless of whether
> running
On Wed, 13 Jan 2021 01:37:40 GMT, Alexey Semenyuk wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/Platform.java line 127:
>>
>>> 125: return is64b;
>>> 126: }
>>> 127:
>>
>> This is Windows specific thing. There is no point to keep it in shared code.
>> I'd suggest
On Tue, 12 Jan 2021 20:49:52 GMT, Alexey Semenyuk wrote:
>> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/Platform.java line 127:
>
>> 125: return is64b;
>> 126: }
>> 127:
>
> This function makes sense onl
On Wed, 13 Jan 2021 01:32:51 GMT, Alexey Semenyuk wrote:
>> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/Platform.java line 127:
>
>> 125: return is64b;
>> 126: }
>> 127:
>
> This is Windows specific thin
On Tue, 12 Jan 2021 22:38:38 GMT, Alexander Matveev
wrote:
>> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
>
> src/jdk.jpackage/share/native/applauncher/JvmLauncher.cpp line 37:
>
>> 35:
>> 36: #if defined(_WIN32) && !defined(_WIN64)
>> 37: #define LAUNCH_FUNC "_JLI_Launch
On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
src/jdk.jpackage/share/native/applauncher/JvmLauncher.cpp line 37:
> 35:
> 36: #if defined(_WIN32) && !defined(_WIN64)
> 37: #define LAUNCH_FUNC "_JLI_Launch@56"
Why JLI_L
JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
-
Commit messages:
- JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
- JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
- JDK-8258755: jpackage: Invalid 32-bit exe when building
On Mon, 11 Jan 2021 17:42:21 GMT, Andy Herrick wrote:
> JDK-8258755: jpackage: Invalid 32-bit exe when building app-image
Changes requested by asemenyuk (Committer).
src/jdk.jpackage/share/native/applauncher/JvmLauncher.h line 37:
> 35: #define LAUNCH_FUNC "JLI_Launch"
> 36: #endif
> 37:
I'd
13 matches
Mail list logo
