two changes:
One to jpackage, when recursively removing directory, when IOException occurs,
record it and continue (deleting as much as possible) before throwing the
exception.
The other to tests, when running jpackage via ProcessBuilder.execute(), set the
"TMP" environment variable to the curre
On Tue, 13 Apr 2021 18:57:20 GMT, Andy Herrick wrote:
> two changes:
> One to jpackage, when recursively removing directory, when IOException
> occurs, record it and continue (deleting as much as possible) before throwing
> the exception.
> The other to tests, when running jpackage via ProcessB
On Tue, 13 Apr 2021 19:48:24 GMT, Alexey Semenyuk wrote:
>> two changes:
>> One to jpackage, when recursively removing directory, when IOException
>> occurs, record it and continue (deleting as much as possible) before
>> throwing the exception.
>> The other to tests, when running jpackage via
On Tue, 13 Apr 2021 20:26:56 GMT, Andy Herrick wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java line 59:
>>
>>> 57:
>>> 58: public static void deleteRecursive(Path directory) throws
>>> IOException {
>>> 59: final IOException [] exception = { (IOException
On Tue, 13 Apr 2021 20:31:38 GMT, Andy Herrick wrote:
>> That seems like overkill. walkFileTree must call visitFile,
>> preVisitDirectory, and postVisitDirectory synchronously, because their
>> return value tells walkFileTree where to go next.
>
> I can use AtomicReference instead of Array to
> two changes:
> One to jpackage, when recursively removing directory, when IOException
> occurs, record it and continue (deleting as much as possible) before throwing
> the exception.
> The other to tests, when running jpackage via ProcessBuilder.execute(), set
> the "TMP" environment variable
On Tue, 13 Apr 2021 21:05:26 GMT, Andy Herrick wrote:
>> two changes:
>> One to jpackage, when recursively removing directory, when IOException
>> occurs, record it and continue (deleting as much as possible) before
>> throwing the exception.
>> The other to tests, when running jpackage via Pro
> two changes:
> One to jpackage, when recursively removing directory, when IOException
> occurs, record it and continue (deleting as much as possible) before throwing
> the exception.
> The other to tests, when running jpackage via ProcessBuilder.execute(), set
> the "TMP" environment variable
On Tue, 13 Apr 2021 22:50:12 GMT, Andy Herrick wrote:
>> two changes:
>> One to jpackage, when recursively removing directory, when IOException
>> occurs, record it and continue (deleting as much as possible) before
>> throwing the exception.
>> The other to tests, when running jpackage via Pro
On Tue, 13 Apr 2021 22:50:12 GMT, Andy Herrick wrote:
>> two changes:
>> One to jpackage, when recursively removing directory, when IOException
>> occurs, record it and continue (deleting as much as possible) before
>> throwing the exception.
>> The other to tests, when running jpackage via Pro
On Tue, 13 Apr 2021 22:50:12 GMT, Andy Herrick wrote:
>> two changes:
>> One to jpackage, when recursively removing directory, when IOException
>> occurs, record it and continue (deleting as much as possible) before
>> throwing the exception.
>> The other to tests, when running jpackage via Pro
On Tue, 13 Apr 2021 21:10:56 GMT, Kevin Rushforth wrote:
> Are you sure you need an `AtomicReference` to set the exception? I don't see
> any use of multiple threads, but I might be missing something. If you do need
> it, you need to fix the order of arguments.
`postVisitDirectory()` and `visi
On Wed, 14 Apr 2021 17:36:21 GMT, Alexey Semenyuk wrote:
> postVisitDirectory() and visitFile() methods can be potentially called
> concurrently by walkFileTree()
I don't think they can.
> Javadoc ... doesn't say anything about synchronization, so I think it is fair
> to assume it is not guar
13 matches
Mail list logo
