Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v4]

2021-07-14 Thread Alexander Matveev
On Wed, 14 Jul 2021 16:50:39 GMT, Andy Herrick wrote: >> JDK-8269387: jpackage --add-launcher should have option to not create >> shortcuts for additional launchers > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v4]

2021-07-14 Thread Alexey Semenyuk
On Wed, 14 Jul 2021 16:50:39 GMT, Andy Herrick wrote: >> JDK-8269387: jpackage --add-launcher should have option to not create >> shortcuts for additional launchers > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v4]

2021-07-14 Thread Andy Herrick
> JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8269387: jpackage --add-launcher should have option to not create

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v3]

2021-07-13 Thread Alexey Semenyuk
On Tue, 13 Jul 2021 16:39:01 GMT, Andy Herrick wrote: >> JDK-8269387: jpackage --add-launcher should have option to not create >> shortcuts for additional launchers > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v3]

2021-07-13 Thread Andy Herrick
> JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8269387: jpackage --add-launcher should have option to not create

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v2]

2021-07-09 Thread Alexey Semenyuk
On Fri, 9 Jul 2021 17:59:35 GMT, Andy Herrick wrote: >> JDK-8269387: jpackage --add-launcher should have option to not create >> shortcuts for additional launchers > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v2]

2021-07-09 Thread Andy Herrick
> JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8269387: jpackage --add-launcher should have option to not create

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

2021-07-08 Thread Alexey Semenyuk
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote: > JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java line 39: > 37: > 38: /* > 39: *

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

2021-07-08 Thread Alexey Semenyuk
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote: > JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers Review test/jdk/tools/jpackage/share/AddLShortcutTest.java line 46: > 44: */ > 45: > 46: /* Why do you need two jtreg @test-s

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

2021-07-08 Thread Alexey Semenyuk
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote: > JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers test/jdk/tools/jpackage/share/AddLShortcutTest.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2020, Oracle and/or its affiliates.

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

2021-07-08 Thread Alexey Semenyuk
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote: > JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java line 259: > 257: for (var name : names) { > 258:

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

2021-07-08 Thread Kevin Rushforth
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote: > JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers This will need a CSR (so you or someone with a Reviewer role should indicate this with the `/csr` command). Also, can you

RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

2021-07-08 Thread Andy Herrick
JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers - Commit messages: - JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers - JDK-8269387: jpackage --add-launcher should