Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Alexander Matveev
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote: > - We need to unsign all executables and libraries in the app-image before > signing. (not just those in the runtime). > - Clean up excessive output by executing the individual file sign and > unsigning commands in quiet mode. > - Add cond

Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Alexey Semenyuk
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote: > - We need to unsign all executables and libraries in the app-image before > signing. (not just those in the runtime). > - Clean up excessive output by executing the individual file sign and > unsigning commands in quiet mode. > - Add cond

RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Andy Herrick
- We need to unsign all executables and libraries in the app-image before signing. (not just those in the runtime). - Clean up excessive output by executing the individual file sign and unsigning commands in quiet mode. - Add conditions in SigningAppImageTest to test signing of additional laun

Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Andy Herrick
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote: > Before signing, unsign all executables and libraries (not just those in > runtime). > Also, run individual file sign and unsign commands in quiet mode. > Also, add test case to SigningAppImageTest to test that signing app that has > additio

Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher [v2]

2021-12-01 Thread Andy Herrick
> Before signing, unsign all executables and libraries (not just those in > runtime). > Also, run individual file sign and unsign commands in quiet mode. > Also, add test case to SigningAppImageTest to test that signing app that has > additional launcher works, and results in validly signed launc

Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Andy Herrick
On Wed, 1 Dec 2021 19:59:57 GMT, Alexey Semenyuk wrote: >> Before signing, unsign all executables and libraries (not just those in >> runtime). >> Also, run individual file sign and unsign commands in quiet mode. >> Also, add test case to SigningAppImageTest to test that signing app that has >>

Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Alexey Semenyuk
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote: > Before signing, unsign all executables and libraries (not just those in > runtime). > Also, run individual file sign and unsign commands in quiet mode. > Also, add test case to SigningAppImageTest to test that signing app that has > additio

RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Andy Herrick
Before signing, unsign all executables and libraries (not just those in runtime). Also, run individual file sign and unsign commands in quiet mode. Also, add test case to SigningAppImageTest to test that signing app that has additional launcher works, and results in validly signed launcher and a