Re: RFR: JDK9: 8037221: [asm] refresh internal ASM version

2014-03-13 Thread Paul Sandoz
Hi, Eye-balled the changes, nothing obvious popped out. Looks good. It's very minor, and should not block the code going back, but occured is a common misspelling of occurred. Paul. On Mar 12, 2014, at 10:24 PM, Kumar Srinivasan kumar.x.sriniva...@oracle.com wrote: Hello, Appreciate if

Re: RFR: JDK9: 8037221: [asm] refresh internal ASM version

2014-03-13 Thread Kumar Srinivasan
Thanks Paul, for the review!. Hi, Eye-balled the changes, nothing obvious popped out. Looks good. It's very minor, and should not block the code going back, but occured is a common misspelling of occurred. fyi, these are *all* changes made upstream, by the ASM team, the only file we

RFR: JDK9: 8037221: [asm] refresh internal ASM version

2014-03-12 Thread Kumar Srinivasan
Hello, Appreciate if someone cane review this change, so that I can push this into the jdk9 repository, refreshing the internal ASM sources from rev 1700 to 1721, of particular interest is Rev 1710, which fixes [1] known to cause verification errors in the VM. Thereafter I will be