Re: RFR: String Density/Compact String JEP 254 (update)

2015-11-03 Thread Paul Sandoz
Hi, This is a significant body of impressive work, well done all who worked on it. String — 148 * The instance field value is generally opaque to optimizing JIT 149 * compilers. Therefore, in performance-sensitive place, an explicit 150 * check of the static boolean {@code COM

Re: RFR: String Density/Compact String JEP 254 (update)

2015-11-01 Thread Xueming Shen
On 11/1/15 10:18 AM, Alan Bateman wrote: On 30/10/2015 21:30, Xueming Shen wrote: Hi, Thanks for the comments/suggestions. Here are the updated webrevs with minor changes here and there based on the feedback. I spent time going through the changes in jdk repo and it looks very good. One th

Re: RFR: String Density/Compact String JEP 254 (update)

2015-11-01 Thread Alan Bateman
On 30/10/2015 21:30, Xueming Shen wrote: Hi, Thanks for the comments/suggestions. Here are the updated webrevs with minor changes here and there based on the feedback. I spent time going through the changes in jdk repo and it looks very good. One thing that isn't clear to me is why StringUTF

Re: RFR: String Density/Compact String JEP 254 (update)

2015-10-30 Thread Xueming Shen
Hi, Thanks for the comments/suggestions. Here are the updated webrevs with minor changes here and there based on the feedback. http://cr.openjdk.java.net/~sherman/8054307/jdk/ http://cr.openjdk.java.net/~thartmann/compact_strings/webrev/hotspot/ [closed, Oracle internal only] http://javaweb.u