Re: RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-19 Thread Joe Wang
On 12/19/2012 6:34 AM, Daniel Fuchs wrote: Hi, Please find below an updated webrev for the javax.xml.transform package, taking into account Mandy's & Joe's comments - namely: 1. Fixed call to creationMethod.invoke. 2. Got rid of the 4 args FactoryFinder.newInstance method. 3. Got rid of the

Re: RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-19 Thread Mandy Chung
On 12/19/2012 6:34 AM, Daniel Fuchs wrote: Thanks for the update and it looks much better. FactoryFinder L214-215: this will swallow the new TransformerFactoryConfigurationError thrown at L210. Maybe you can

Re: RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-19 Thread Daniel Fuchs
Hi, Please find below an updated webrev for the javax.xml.transform package, taking into account Mandy's & Joe's comments - namely: 1. Fixed call to creationMethod.invoke. 2. Got rid of the 4 args FactoryFinder.newInstance method. 3. Got rid of the useBSClsLoader which was always passed as 'fa

Re: RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-18 Thread Daniel Fuchs
On 12/18/12 7:38 PM, Joe Wang wrote: Hi Daniel, Looks great! I see you've added many verifications. One minor note, creationMethod is used in place of the object instance for the creationMethod.invoke call, although it's ignored for a static method anyways. Is there a reason for doing that?

Re: RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-18 Thread Daniel Fuchs
On 12/18/12 9:06 PM, Mandy Chung wrote: In FactoryFinder.newInstanceNoServiceLoader method, L223, 226 - NoSuchMethodException will be thrown if such method doesn't exist. creationMethod will not be null. Thanks - yes - you're right of course - no need to check for null... L236 - this change is

Re: RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-18 Thread Mandy Chung
On 12/18/12 8:42 AM, Daniel Fuchs wrote: Hi, Here is a new webrev in the series that addresses using ServiceLoader in JAXP for JDK 8. 7169894: JAXP Plugability Layer: using service loader This changeset addresses modification in the javax.xml.transform package. It is similar to changes propose

Re: RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-18 Thread Joe Wang
Hi Daniel, Looks great! I see you've added many verifications. One minor note, creationMethod is used in place of the object instance for the creationMethod.invoke call, although it's ignored for a static method anyways. Is there a reason for doing that? -Joe On 12/18/2012 8:42 AM, Daniel

RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-18 Thread Daniel Fuchs
Hi, Here is a new webrev in the series that addresses using ServiceLoader in JAXP for JDK 8. 7169894: JAXP Plugability Layer: using service loader This changeset addresses modification in the javax.xml.transform package. It is similar to changes proposed for the javax.xml.parsers package [1], w