Hi Nadeesh,
Looks good, thanks for the extra test cases.
I'll sponsor this for you a push it presently.
Roger
On 10/19/2015 2:59 AM, nadeesh tv wrote:
HI all,
Please review the updated webrev
http://cr.openjdk.java.net/~ntv/8134928/webrev.01/
Regards,
Nadeesh
On 10/14/2015 4:06 PM,
HI all,
Please review the updated webrev
http://cr.openjdk.java.net/~ntv/8134928/webrev.01/
Regards,
Nadeesh
On 10/14/2015 4:06 PM, Stephen Colebourne wrote:
I'd like to see an additional test case for the cases where rounding
is *not* needed. Currently, there are only tests for where rounding
Hi all,
Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8134928
Issue- java.time.Instant.truncatedTo(TemporalUnit unit) is truncating up
if the year < 1970
BugId - https://bugs.openjdk.java.net/browse/JDK-8134928
webrev -
I'd like to see an additional test case for the cases where rounding
is *not* needed. Currently, there are only tests for where rounding is
needed. It needs one more test line for after 1970 and one for before
1970.
thanks
Stephen
On 14 October 2015 at 10:53, nadeesh tv